Update eth-snap-keyring to 0.2.x to use the keyring-api 0.2.x

[danroc]

Explanation

This PR updates the version of the eth-snap-keyring to use the new version of the keyring-api that we plan to expose to snap developers.

This PR has no other impacts, and only affects Flask.

BREAKING CHANGE: The keyring-api 0.2.x is incompatible with the previous 0.1.x release. Snaps developed with version 0.1.x of the API need to migrate to 0.2.x.

Manual Testing Steps

1. Install the SSK from the SSK dapp.
2. Create an account using the SSK dapp.
   1. Note that the account name defined in the SSK dapp will be ignored.
3. Use the test dapp to sign transactions using the sync and async flows.
   1. There is a toggle in the SSK dapp to switch between the flows.

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[danroc]

@metamaskbot update-policies

[socket-security]

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @metamask-institutional/portfolio-dashboard@1.4.0, @metamask/eth-snap-keyring@0.1.4, @metamask/rpc-methods@0.35.2-flask.1, @metamask/snaps-controllers@0.35.2-flask.1, @metamask/snaps-ui@0.35.2-flask.1, @metamask/snaps-utils@0.35.2-flask.1

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue	Package	Version	Note	Source
Network access	@storybook/manager	7.0.12	Module: globalThis["fetch"] Location: dist/chunk-GZZF3RWZ.js +1 more instances...	storybook@7.0.12 via package.json

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore @storybook/manager@7.0.12

[metamaskbot]

Policies updated

[HowardBraham]

It's not working for me, when I try to Create Account I get this error:

{"code":-32603,"message":"Method not supported: createAccount","data":{"originalError":{}}}

[danroc]

Indeed @HowardBraham, I'll publish the new SSK that works with this branch (0.2.1).

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (0bc3aa9) 68.38% compared to head (7496857) 68.38%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #20865   +/-   ##
========================================
  Coverage    68.38%   68.38%           
========================================
  Files         1006     1006           
  Lines        40244    40244           
  Branches     10759    10760    +1     
========================================
+ Hits         27517    27518    +1     
+ Misses       12727    12726    -1     

Files Changed	Coverage Δ
app/scripts/metamask-controller.js	53.86% <0.00%> (+0.05%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[plasmacorral]

Manually tested on Mac Ventura 13.5.2 primarily with Chrome 117, but also Firefox 117.

• Confirmed happy path snap install and account creation, both sending and signing transactions in both sync and async mode with a Snap created account from SSK v0.2.3.
• Confirmed with multiple versions of SSK using multiple sets of accounts created by multiple snap installations that a user can send/sign from either set of accounts with the test dapp.
• Accounts created in SSK 0.2.2 remain usable for sign/send after update to v0.2.3

[danroc]

@metamaskbot update-policies

[metamaskbot]

No policy changes

[danroc]

@metamaskbot update-policies

[metamaskbot]

Policies updated

[metamaskbot]

Builds ready [49823b7]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6, 7
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1769 ± 59 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	129	183	156	17	8
		domContentLoaded	1571	2014	1769	123	59
		load	1571	2014	1769	123	59
		domInteractive	1571	2014	1769	123	59

Bundle size diffs [🚀 Bundle size reduced!]

• background: -43.51 KiB (-1.21%)
• ui: 0 Bytes (0.00%)
• common: -1.38 KiB (-0.03%)

[jiexi]

Wondering if my PR here relates to this one at all

[danroc]

Yes @jiexi, we will soon release a new version of the eth-snap-keyring (including your PR), and update the extension again.

[metamaskbot]

Builds ready [7496857]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6, 7
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1735 ± 112 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	121	240	158	31	15
		domContentLoaded	1360	2114	1734	233	112
		load	1360	2114	1735	233	112
		domInteractive	1360	2114	1734	233	112

Bundle size diffs [🚀 Bundle size reduced!]

• background: -43.51 KiB (-1.21%)
• ui: 0 Bytes (0.00%)
• common: -1.38 KiB (-0.03%)