Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version v11.5.0 #21614

Merged
merged 129 commits into from
Nov 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
129 commits
Select commit Hold shift + click to select a range
4b2e4ad
Merge origin/develop into master-sync
danjm Oct 13, 2023
8646a76
Picker network updates (#21301)
georgewrmarshall Oct 13, 2023
69316d2
Add `data-testid` for toggle button (#21337)
montelaidev Oct 13, 2023
8235fa2
UX: Multichain: Use contants for AssetListConversionButton variants (…
darkwing Oct 13, 2023
b0c0c35
Fixing truncation and alignment in the network toggle component (#21370)
georgewrmarshall Oct 13, 2023
212e263
[MMI] updates metamask/keyring-controller package to latest version (…
zone-live Oct 13, 2023
e471f0a
fix(21300): bring back appInstalled event when opt in (#21357)
DDDDDanica Oct 13, 2023
5c7ac0f
fix(000): fix lint for account-list-item-menu and token-allowance (#2…
DDDDDanica Oct 13, 2023
b8c9f3f
UX: Fixed network picker in header (#21374)
NidhiKJha Oct 13, 2023
a3b78f0
Add min-width support to Box DS component; Fix Blockaid Security Aler…
digiwand Oct 13, 2023
384ba3d
UX Multichain: Added avatar group component (#21342)
NidhiKJha Oct 13, 2023
6e82ec2
UX: Multichain: Fix useAccountTotalFiatBalance when getWeiHexFromDeci…
darkwing Oct 13, 2023
001c94b
fix: display conversion rate (#21185)
sahar-fehri Oct 13, 2023
9d1bd43
Token amount sent displays 0 when input contains no decimals (#21338)
salimtb Oct 13, 2023
0bec1df
Fix gas calculation checking wrong account balance (#21174)
bergeron Oct 13, 2023
d3c87e5
Merge pull request #21365 from MetaMask/master-sync
danjm Oct 13, 2023
0c3c3fc
UX: Multichain: Send flow: Send page skeleton (#21250)
darkwing Oct 13, 2023
a1fad6a
fix(000): fix mv3 build (#21320)
DDDDDanica Oct 13, 2023
c23b1b5
Bump test-dapp to v7.2.0 (#21358)
digiwand Oct 13, 2023
e614498
fix: don't render attribute `aria-invalid="false"` (#20939)
HowardBraham Oct 14, 2023
1a597a5
Adopt new version of `@metamask/signature-controller` to add signatur…
OGPoyraz Oct 16, 2023
c90c274
fix: Hex data should be cleared out during ERC20 Send (#21336)
salimtb Oct 17, 2023
4af7578
chore: Blockaid remove unfair_trade reason type (#21386)
digiwand Oct 17, 2023
957c8b9
test: Fix flaky e2e tests | Add retry logic to switchToWindowWithTitl…
digiwand Oct 17, 2023
98e77b8
Fix #21169 - Ensure Copy format is plain text (#21387)
darkwing Oct 17, 2023
e8cd9c2
Security provider metrics fix (#21390)
jpuri Oct 17, 2023
3bc7780
Enable blockaid in main build (#21352)
jpuri Oct 17, 2023
5863649
Wrap the getFormattedIpfsUrl call in getAssetImageURL in a try catch,…
danjm Oct 18, 2023
239f0c5
Await account render after unlock before checking for mocked endpoint…
danjm Oct 18, 2023
9a3b006
Remove CODEOWNERS entry for Flask files (#21406)
FrederikBolding Oct 18, 2023
913d0fb
deps/devDeps: Bump babel and storybook packages to latest (#21397)
legobeat Oct 18, 2023
91f6a0d
test:fix:e2e Fix flaky PPOM Blockaid tests by adding more mock JSON-A…
digiwand Oct 18, 2023
f0d81dc
Fix NEAR protocol path (#21427)
FrederikBolding Oct 18, 2023
c5a083f
Fix cannot read `code` property of undefined (#21435)
vinistevam Oct 18, 2023
fd84e8b
fix: ERC20 Custom Token shows incorrect name (#21401)
salimtb Oct 18, 2023
703f4ba
Remove NetworkId (#20652)
jiexi Oct 18, 2023
09d1e0e
Fix: metrics details for toggling blockaid settings (#21389)
jpuri Oct 19, 2023
a268d88
test: move ppom e2e tests to run against the main build (#21424)
seaona Oct 19, 2023
96d0dfe
Add Snaps to three dots menu and refactor (#21329)
david0xd Oct 19, 2023
31ecd11
Revert e471f0adec and then replace onInstalled event with check for e…
danjm Oct 19, 2023
f748db3
Decouple `MetaMetricsController` from `TxController` (#21330)
OGPoyraz Oct 19, 2023
0c8a8a8
feat(20169): remove service worker restart related e2e tests (#21439)
DDDDDanica Oct 19, 2023
78f73bd
fix(issue template): placeholder text (#21414)
gauthierpetetin Oct 19, 2023
0406b6e
feat(21068): remove action queue for new MV3 (#21410)
DDDDDanica Oct 19, 2023
b72a418
Simplify notifications implementation (#21455)
FrederikBolding Oct 19, 2023
dcfbfef
UX: Remove unused KeyringLabel and allcaps style (#21446)
darkwing Oct 19, 2023
3457b2b
UX: Remove PickerNetwork active background color change when disabled…
darkwing Oct 19, 2023
270c841
fix(21069): remove sleepSeconds (#21459)
DDDDDanica Oct 19, 2023
f2be12c
e2e: better split of tests running on parallel machines (#21441)
HowardBraham Oct 19, 2023
e79cedc
Update e2e snapshot (#21457)
PeterYinusa Oct 19, 2023
9c54a65
ci(privacy): add mozilla.org to privacy ignore list (#21415)
brad-decker Oct 19, 2023
99e254c
[e2e] Switch ethereum chain multiple dapps (#21356)
tmashuang Oct 19, 2023
ffe2d52
test: add unit tests to `getSnapAndHardwareInfoForMetrics` method (#2…
gantunesr Oct 19, 2023
359409c
test: fix `getSnapAndHardwareInfoForMetrics` unit test (#21469)
gantunesr Oct 19, 2023
5d34d68
Update assets controllers to version 16 (#21380)
pedronfigueiredo Oct 20, 2023
d6180fe
Add new test scenarios send tokens
chloeYue Oct 20, 2023
a2261e1
UX: Remove large-input style (#21449)
darkwing Oct 20, 2023
8aa0f9a
chore(000): update chrome driver version to 118 (#21472)
DDDDDanica Oct 20, 2023
3d7f571
Enable Linea (#21104)
infiniteflower Oct 20, 2023
61a66df
Fix/issue template (#21475)
gauthierpetetin Oct 20, 2023
b9f75cf
fix(linea): enable token detection for Linea mainnet and testnet (#20…
gauthierpetetin Oct 20, 2023
6927235
UX: Reduce setMouseUserState calls to prevent re-renders (#21443)
darkwing Oct 20, 2023
31c48f3
UX: Remove AccountPicker hover styling when disabled (#21451)
darkwing Oct 20, 2023
22fe673
Multichain send page components (#21395)
darkwing Oct 20, 2023
2da9fc3
Fix flakiness of import-flow.spec.js and swaps-notifications.spec.js …
danjm Oct 20, 2023
8e6631f
Simplify keep alive logic (#21385)
pedronfigueiredo Oct 20, 2023
0bc1d38
E2e multiple erc20 watch asset (#21381)
tmashuang Oct 20, 2023
f5942b1
add figma storybook addon (#21468)
garrettbear Oct 20, 2023
3143e8a
fix: fix reading address of undefined error (#21400)
sahar-fehri Oct 23, 2023
416c8ff
fix(action): ensure retrocompatibility of issue template check (#21478)
gauthierpetetin Oct 23, 2023
8a96c2b
feat: Metrics for when Blockaid banner is shown. (#21396)
segun Oct 23, 2023
414596e
Rename `err` property to `error` in the transaction meta (#21463)
vinistevam Oct 24, 2023
ef8403f
Use a translation for Linea (#21513)
danjm Oct 24, 2023
37b191b
Merge origin/develop into master-sync
danjm Oct 24, 2023
8b0d394
fix: ERC20 Custom Token shows incorrect icon (#21508)
salimtb Oct 24, 2023
67d7712
UX: Multichain: Send Flow: Move connected components to individual co…
darkwing Oct 24, 2023
224123e
Update links to docs in the README (#21194)
Montoya Oct 24, 2023
837f6cb
PR template update (#21377)
georgewrmarshall Oct 24, 2023
b94e37d
e2e: fix local run-all command (#21510)
HowardBraham Oct 24, 2023
bec7812
UX: Multichain: Send Flow: Add setup and cleanup hooks (#21506)
darkwing Oct 24, 2023
5ae6995
UX: Multichain: Send: AccountPicker Wiring (#21503)
darkwing Oct 24, 2023
7b87054
UX: Multichain: Send Flow: Wire Network Picker (#21502)
darkwing Oct 24, 2023
1cb36fa
feat: snap accounts legal disclaimer (#21525)
gantunesr Oct 24, 2023
43ac46a
fix: #21502 caused a problem with unit tests (#21532)
HowardBraham Oct 25, 2023
450073e
UX Multichain: Show associate token symbols with account balances (#2…
NidhiKJha Oct 25, 2023
4ea5251
feat(21438): remove action queue related config (#21460)
DDDDDanica Oct 25, 2023
f1b1163
Merge pull request #21514 from MetaMask/master-sync
danjm Oct 25, 2023
2d55670
Update ppom validator to version 0.8.0 (#21518)
jpuri Oct 25, 2023
a3085c1
update manual QA flows documentation (#21540)
benjisclowder Oct 25, 2023
2205735
Add terms of use to security alerts settings (#21466)
segun Oct 25, 2023
0a261a8
feat: Add metrics for provider calls coming from ppom on extension (#…
segun Oct 25, 2023
ad614e9
Rewrite logic which checks creates noTxHashError in MMI code fence (#…
shane-t Oct 26, 2023
2fcdf49
Fix `hasApprovalFlows` condition (#21538)
FrederikBolding Oct 26, 2023
04e5842
fix: Show number of tokens to be imported (#21521)
sahar-fehri Oct 26, 2023
a592f92
feat(actions): refactoring + improvement of github actions (#21497)
gauthierpetetin Oct 26, 2023
1c9b24e
Bump snaps packages (#21493)
FrederikBolding Oct 26, 2023
3801fda
E2e nft detection (#21520)
PeterYinusa Oct 26, 2023
4a08daf
Add new test scenarios (#20785)
tmashuang Oct 26, 2023
67134ec
UX: Multichain: Create Circle CI job for MULTICHAIN feature flag (#21…
darkwing Oct 26, 2023
6ec2feb
updated label for buy and sell (#21568)
NidhiKJha Oct 26, 2023
4abd419
UX: Multichain: Standardize CSS imports (#21531)
darkwing Oct 26, 2023
6543901
UX: Multichain: Send Flow: Wire To / Your Accounts (#21504)
darkwing Oct 26, 2023
845043a
ci(chore): Run snaps tests in main unit test job (#21543)
brad-decker Oct 26, 2023
bce572a
Updating AccountPicker component to allow for customizations (#21544)
georgewrmarshall Oct 27, 2023
c8a18f6
update install/update snap headers (#21541)
GuillaumeRx Oct 27, 2023
5e5290b
Add test scenarios for gas fee (#21537)
chloeYue Oct 27, 2023
7496ca4
ci(chore): make multichain tests non required (#21586)
brad-decker Oct 27, 2023
d679ec3
Add test scenario connect hardware wallet (#21561)
chloeYue Oct 27, 2023
4887971
Merge origin/develop into master-sync
danjm Oct 27, 2023
5d8957e
UX: Fix alignment of legacy connect text (#21552)
darkwing Oct 27, 2023
3b3bfae
E2e folder structure (#21582)
PeterYinusa Oct 28, 2023
19cf32f
UX: Multichain: Send Flow: Wire back and cancel buttons (#21524)
darkwing Oct 31, 2023
6bffbab
Merge pull request #21594 from MetaMask/master-sync
danjm Oct 31, 2023
923815c
v11.5.0
danjm Oct 31, 2023
9b38e79
test: disable `it` failing block for ppom malicious signature (#21627)
seaona Oct 31, 2023
b76f0a7
e2e: add Snap Accounts ethSign test, convert to TypeScript, optimize …
HowardBraham Oct 31, 2023
0e2f8dd
fix erc1155 test flakiness (#21628)
pedronfigueiredo Nov 1, 2023
e0d946d
Mocking IPFS requests on erc1155 tests (#21639)
pedronfigueiredo Nov 1, 2023
9288883
Merge pull request #21650 from MetaMask/rc-v11.5.0-flakiness
pedronfigueiredo Nov 1, 2023
560a811
[MMI] passing the selectedAddress field (#21617) (#21675)
zone-live Nov 3, 2023
2cb4efe
Cherry-pick a8a6d0a (PR #21691) in v11.5.0
micaelae Nov 6, 2023
034f3a3
Cherry-pick snaps files hotfix (#21714)
FrederikBolding Nov 7, 2023
b2bf175
Cherry-pick ed36028 (#21690) to v11.5.0
danjm Nov 10, 2023
808869f
Cherrypicking 32b249a (#21710) into v11.5.0. (#21769)
blackdevelopa Nov 10, 2023
a114092
Revert "feat: Metrics for when Blockaid banner is shown. (#21396)" (#…
seaona Nov 10, 2023
e2b4c89
Revert "feat: Add metrics for provider calls coming from ppom on exte…
seaona Nov 10, 2023
b65c97d
Merge branch 'master' into Version-v11.5.0
danjm Nov 10, 2023
a63c961
Update changelog v11.5.0 (#21683)
pedronfigueiredo Nov 10, 2023
6fc4ca6
Cherry pick b0cabd535c (PR #21796) v11.5.0 (#21797)
danjm Nov 10, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
224 changes: 75 additions & 149 deletions .circleci/config.yml

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions .circleci/scripts/chrome-install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ set -o pipefail
sudo apt-get update

# To get the latest version, see <https://www.ubuntuupdates.org/ppa/google_chrome?dist=stable>
CHROME_VERSION='116.0.5845.179-1'
CHROME_VERSION='118.0.5993.88-1'
CHROME_BINARY="google-chrome-stable_${CHROME_VERSION}_amd64.deb"
CHROME_BINARY_URL="https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/${CHROME_BINARY}"

# To retrieve this checksum, run the `wget` and `shasum` commands below
CHROME_BINARY_SHA512SUM='cbdad3f5c928ef79a46a3619054b3c4a73a99f942f9bf4ea75d37d6434912da5c01f6ee30718a58e869ff6b57b10bb7fea1cf91885a25aac290a50a2ee3c03c4'
CHROME_BINARY_SHA512SUM='cae6a5cd8632ad350b41f4dfaf80449e6cf19d0b02816b9a1600f54b15df2adf5c4ded3792bfbe3855fa11a79ea256622f50180aa3c6779cedd75a55e7a6da9d'

wget -O "${CHROME_BINARY}" -t 5 "${CHROME_BINARY_URL}"

Expand Down
2 changes: 2 additions & 0 deletions .depcheckrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ ignores:
- 'geckodriver'
- 'jest'
- 'lavamoat-viz'
- 'mocha-junit-reporter'
- 'prettier-plugin-sort-json' # automatically imported by prettier
- 'source-map-explorer'
- 'playwright'
Expand All @@ -41,6 +42,7 @@ ignores:
# storybook
- '@storybook/cli'
- '@storybook/core'
- '@storybook/addon-designs'
- '@storybook/addon-essentials'
- '@storybook/addon-a11y'
- '@storybook/addon-mdx-gfm'
Expand Down
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/bug-report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ body:
label: Expected behavior
description: What did you expect to happen?
- type: textarea
id: screenshot
id: screenshot-recording
attributes:
label: Screenshots
description: Please include screenshots if applicable!
label: Screenshots/Recordings
description: Please include screenshots/recordings if applicable! (https://recordit.co/ is recommended)
- type: textarea
id: reproduce
attributes:
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/general-issue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ body:
id: description
attributes:
label: What is this about?
placeholder: Describe the issue here.
placeholder: As a user, describe the issue here.
validations:
required: true

Expand Down
2 changes: 1 addition & 1 deletion .github/guidelines/LABELING_GUIDELINES.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ To maintain a consistent and efficient development workflow, we have set specifi
### Mandatory team labels:
- **Internal Developers**: Every PR raised by an internal developer must include a label prefixed with `team-` (e.g., `team-extension-ux`, `team-extension-platform`, etc.). This indicates the respective internal team responsible for the PR.

- **External Contributors**: PRs from contributors outside the organization must have the `external-contributor` label.
- **External Contributors**: PRs submitted by contributors who are not part of the organization will be automatically labeled with `external-contributor`.

It's essential to ensure that PRs have the appropriate labels before they are considered for merging.

Expand Down
44 changes: 23 additions & 21 deletions .github/pull-request-template.md
Original file line number Diff line number Diff line change
@@ -1,41 +1,43 @@
## **Description**
_Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:_
_1. What is the reason for the change?_
_2. What is the improvement/solution?_

<!--
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes: #

## **Manual testing steps**

_1. Step1:_
_2. Step2:_
_3. ..._
1. Go to this page...
2.
3.

## **Screenshots/Recordings**

_If applicable, add screenshots and/or recordings to visualize the before and after of your change._
<!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. -->

### **Before**

_[screenshot]_
<!-- [screenshots/recordings] -->

### **After**

_[screenshot]_

## **Related issues**

_Fixes #???_
<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained:
- [ ] What problem this PR is solving.
- [ ] How this problem was solved.
- [ ] How reviewers can test my changes.
- [ ] I’ve indicated what issue this PR is linked to: Fixes #???
- [ ] I’ve included tests if applicable.
- [ ] I’ve documented any added code.
- [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
- [ ] I've clearly explained what problem this PR is solving and how it is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors.
- [ ] I’ve properly set the pull request status:
- [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".
Expand Down
Loading
Loading