-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add alternative build process to enable faster developer builds #22506
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
e18f3fa
to
ba12d0d
Compare
858b9b4
to
d2a1411
Compare
09b9ec4
to
57d85d5
Compare
b72dddd
to
896f454
Compare
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again. Next stepsWhat is network access?This module accesses the network. Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use. What is shell access?This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code. Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
1713a7f
to
63f591f
Compare
17a1d41
to
3f04e83
Compare
Builds ready [dea1e34]
Page Load Metrics (622 ± 371 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [b7dc749]
Page Load Metrics (146 ± 161 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [9ec67bd]
Page Load Metrics (151 ± 205 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
@davidmurdoch, looks like this step is failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! Awesome work @davidmurdoch
This will go away once we merge. |
b5cedd6
Quality Gate passedIssues Measures |
Builds ready [27872ae]
Page Load Metrics (237 ± 244 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Closes https://github.com/MetaMask/MetaMask-planning/issues/1477 and https://github.com/MetaMask/MetaMask-planning/issues/1903
Prereq PR: #25456
About this PR
This PR adds an alternative build process that is much faster than the gulp build we have now, which is quite slow and doesn't make use of modern build system improvements. The speed up is possible by making use of the SWC compiler, and more modern build system. The build system is also a bit simpler and hopefully more maintainable.
This build doesn't yet support:
Proposed Review Tactics
There is a lot to review in this PR. Depending on your own review methodologies, you might like the idea of breaking up review into several review passes, each one in a different categories/tactics. Some useful categories may cover things like:
What's bad and should be discussed:
Linking the test ticket here https://github.com/MetaMask/MetaMask-planning/issues/2705