Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow onboarding and unlocking wallet without Infura mainnet connectivity #23388

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Mar 8, 2024

Description

Fixes issue where custom networks are not configurable until after wallet is unlocked.

Open in GitHub Codespaces

Related issues

Manual testing steps

  1. Fresh wallet, disconnect internet, custom RPC node
  2. Open MetaMask
  3. Add custom RPC node
  4. Complete onboarding

Screenshots/Recordings

Before

no-add-network-p.mp4

After

can-add-network-p.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Mar 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat marked this pull request as ready for review March 8, 2024 06:10
@legobeat legobeat requested a review from a team as a code owner March 8, 2024 06:10
@legobeat legobeat changed the title fix: allow onboarding without Infura mainnet connectivity fix: allow onboarding and unlocking wallet without Infura mainnet connectivity Mar 8, 2024
@legobeat legobeat requested a review from kumavis March 8, 2024 06:24
@legobeat legobeat force-pushed the fix-unlocked-network-selection branch from c3aa7dd to cdaee62 Compare March 8, 2024 08:16
@legobeat legobeat requested a review from a team March 8, 2024 11:14
@legobeat legobeat force-pushed the fix-unlocked-network-selection branch 3 times, most recently from 8a328c8 to f4e1fe9 Compare March 12, 2024 09:44
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.72%. Comparing base (6e397d0) to head (4ebb6fd).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #23388      +/-   ##
===========================================
- Coverage    68.72%   68.72%   -0.00%     
===========================================
  Files         1124     1124              
  Lines        43606    43605       -1     
  Branches     11669    11668       -1     
===========================================
- Hits         29967    29965       -2     
- Misses       13639    13640       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legobeat legobeat force-pushed the fix-unlocked-network-selection branch from f4e1fe9 to 9b06bc6 Compare March 12, 2024 10:44
@legobeat legobeat force-pushed the fix-unlocked-network-selection branch from 9b06bc6 to 4ebb6fd Compare March 13, 2024 01:48
@legobeat legobeat merged commit ef0e1a8 into MetaMask:develop Mar 13, 2024
64 of 65 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
@metamaskbot metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 26, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-11.14.0 on PR, as PR was added to branch 11.14.0 when release was cut.

@legobeat legobeat deleted the fix-unlocked-network-selection branch March 27, 2024 05:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.14.0 Issue or pull request that will be included in release 11.14.0 team-security type-bug type-security
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Can not add custom network during onboarding
4 participants