-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow onboarding and unlocking wallet without Infura mainnet connectivity #23388
fix: allow onboarding and unlocking wallet without Infura mainnet connectivity #23388
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
c3aa7dd
to
cdaee62
Compare
8a328c8
to
f4e1fe9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23388 +/- ##
===========================================
- Coverage 68.72% 68.72% -0.00%
===========================================
Files 1124 1124
Lines 43606 43605 -1
Branches 11669 11668 -1
===========================================
- Hits 29967 29965 -2
- Misses 13639 13640 +1 ☔ View full report in Codecov by Sentry. |
f4e1fe9
to
9b06bc6
Compare
9b06bc6
to
4ebb6fd
Compare
No release label on PR. Adding release label release-11.14.0 on PR, as PR was added to branch 11.14.0 when release was cut. |
Description
Fixes issue where custom networks are not configurable until after wallet is unlocked.
Related issues
Manual testing steps
Screenshots/Recordings
Before
no-add-network-p.mp4
After
can-add-network-p.mp4
Pre-merge author checklist
Pre-merge reviewer checklist