-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove repetitive words #23421
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have read the CLA Document and I hereby sign the CLA |
Signed-off-by: cuithon <dscs@outlook.com>
@@ -254,7 +254,7 @@ describe('Transaction Selectors', () => { | |||
}); | |||
|
|||
describe('nonceSortedTransactionsSelector', () => { | |||
it('returns transaction group nonce sorted tx from from selectedTxList wit', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol, there's a second problem on this line. Clearly that was supposed to say from selectedTxList with _______
but it got cut off. Does anyone know what this was supposed to say?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's a bit strange? Should I roll back the modifications here first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, your modifications are fine, but I guess we should try to figure out what that line was supposed to say. I looked at Git history and I think it was always cut off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything need i to do~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think actually let's just remove the word wit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think actually let's just remove the word
wit
Thanks for your replay.
Removed
Signed-off-by: cuithon <dscs@outlook.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23421 +/- ##
===========================================
- Coverage 65.42% 65.42% -0.00%
===========================================
Files 1380 1380
Lines 54688 54688
Branches 14339 14339
===========================================
- Hits 35776 35775 -1
- Misses 18912 18913 +1 ☔ View full report in Codecov by Sentry. |
No release label on PR. Adding release label release-12.2.0 on PR, as PR was added to branch 12.2.0 when release was cut. |
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist