Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove repetitive words #23421

Merged
merged 4 commits into from
Jun 20, 2024
Merged

chore: remove repetitive words #23421

merged 4 commits into from
Jun 20, 2024

Conversation

cuithon
Copy link
Contributor

@cuithon cuithon commented Mar 12, 2024 •
edited by HowardBraham
Loading

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cuithon cuithon requested a review from a team as a code owner March 12, 2024 07:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 12, 2024 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cuithon
Copy link
Contributor Author

cuithon commented Mar 12, 2024

I have read the CLA Document and I hereby sign the CLA

@cuithon @HowardBraham
chore: remove repetitive words
95c86c8 
Signed-off-by: cuithon <dscs@outlook.com>
HowardBraham
HowardBraham reviewed Mar 13, 2024
View reviewed changes
ui/selectors/transactions.test.js
@@ -254,7 +254,7 @@ describe('Transaction Selectors', () => {
});

describe('nonceSortedTransactionsSelector', () => {
it('returns transaction group nonce sorted tx from from selectedTxList wit', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, there's a second problem on this line. Clearly that was supposed to say from selectedTxList with _______ but it got cut off. Does anyone know what this was supposed to say?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's a bit strange? Should I roll back the modifications here first?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, your modifications are fine, but I guess we should try to figure out what that line was supposed to say. I looked at Git history and I think it was always cut off.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything need i to do~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think actually let's just remove the word wit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think actually let's just remove the word wit

Thanks for your replay.

Removed

@HowardBraham HowardBraham added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 25, 2024
@hjetpoluru hjetpoluru self-requested a review May 7, 2024 15:31
@HowardBraham HowardBraham requested a review from a team as a code owner June 16, 2024 19:44
@codecov Codecov
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.42%. Comparing base (624763a) to head (149b659).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #23421      +/-   ##
===========================================
- Coverage    65.42%   65.42%   -0.00%     
===========================================
  Files         1380     1380              
  Lines        54688    54688              
  Branches     14339    14339              
===========================================
- Hits         35776    35775       -1     
- Misses       18912    18913       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HowardBraham HowardBraham merged commit b8bd980 into MetaMask:develop Jun 20, 2024
74 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Aug 19, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-12.2.0 on PR, as PR was added to branch 12.2.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HowardBraham HowardBraham HowardBraham approved these changes

@brianacnguyen brianacnguyen brianacnguyen approved these changes

@garrettbear garrettbear garrettbear approved these changes

@hjetpoluru hjetpoluru hjetpoluru approved these changes

@georgewrmarshall georgewrmarshall Awaiting requested review from georgewrmarshall

Assignees
No one assigned
Labels
external-contributor needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-12.2.0 Issue or pull request that will be included in release 12.2.0
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cuithon @metamaskbot @HowardBraham @brianacnguyen @garrettbear @hjetpoluru