Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove repetitive words #23421

Merged
merged 4 commits into from
Jun 20, 2024
+2 −2
Merged

chore: remove repetitive words #23421

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95c86c8
chore: remove repetitive words
cuithon Mar 12, 2024
60595da
Merge branch 'develop' into develop
HowardBraham Apr 24, 2024
bff1b01
chore: remove repetitive words
cuithon Apr 25, 2024
149b659
Merge branch 'develop' into develop
HowardBraham Jun 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/components/component-library/icon/README.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ If your svg **does not** contain a single path, you will need to get a designer

#### Step 2.

Add your optimized svg file to to `app/images/icons`
Add your optimized svg file to `app/images/icons`

#### Step 3.

Expand Down
2 changes: 1 addition & 1 deletion ui/selectors/transactions.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ describe('Transaction Selectors', () => {
});

describe('nonceSortedTransactionsSelector', () => {
it('returns transaction group nonce sorted tx from from selectedTxList wit', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, there's a second problem on this line. Clearly that was supposed to say from selectedTxList with _______ but it got cut off. Does anyone know what this was supposed to say?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's a bit strange? Should I roll back the modifications here first?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, your modifications are fine, but I guess we should try to figure out what that line was supposed to say. I looked at Git history and I think it was always cut off.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything need i to do~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think actually let's just remove the word wit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think actually let's just remove the word wit

Thanks for your replay.

Removed

it('returns transaction group nonce sorted tx from selectedTxList wit', () => {
const tx1 = {
id: 0,
time: 0,
Expand Down
Loading