-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent rpc request before onboarding is completed #23622
fix: Prevent rpc request before onboarding is completed #23622
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
d16dad8
to
91acfcc
Compare
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
@SocketSecurity ignore npm/@metamask/safe-event-emitter@3.0.0 |
Builds ready [91acfcc]
Page Load Metrics (1381 ± 563 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left two comments
1b78a96
to
837e12d
Compare
.yarn/patches/@metamask-network-controller-npm-18.0.1-c4d0cfaecd.patch
Outdated
Show resolved
Hide resolved
Builds ready [7e532de]
Page Load Metrics (1019 ± 588 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
63af236
to
536ab0a
Compare
430c5cd
to
3988377
Compare
Builds ready [3988377]
Page Load Metrics (1232 ± 496 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
The temporary solution is to:
The long term solution will be #23005 (currently blocked by #4004 on core.
Related issues
Fixes: https://github.com/MetaMask/metamask-planning/issues/881
Manual testing steps
await new Promise((resolve) => setTimeout(resolve, 10000));
to the top of initialize on the background.js fileScreenshots/Recordings
Before
Peek.2023-12-05.06-44.mp4
After
Peek.2023-12-05.06-31.mp4
Pre-merge author checklist
Pre-merge reviewer checklist