-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Typescript conversion of log-web3-shim-usage.js #23732
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
c063564
to
f1e8bd0
Compare
0a09193
to
4afeae1
Compare
Builds ready [975bbe0]
Page Load Metrics (1026 ± 503 ms)
Bundle size diffs
|
e89505c
to
fca464b
Compare
This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions. |
This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #23732 +/- ##
========================================
Coverage 70.14% 70.14%
========================================
Files 1424 1424
Lines 49572 49572
Branches 13868 13868
========================================
Hits 34769 34769
Misses 14803 14803 ☔ View full report in Codecov by Sentry. |
Builds ready [aac4215]
Page Load Metrics (57 ± 7 ms)
Bundle size diffs
|
c93945b
to
cb7ad5d
Compare
Quality Gate passedIssues Measures |
Builds ready [cb7ad5d]
Page Load Metrics (308 ± 272 ms)
Bundle size diffs
|
855fab5
to
9000e66
Compare
Quality Gate passedIssues Measures |
Builds ready [9000e66]
Page Load Metrics (1824 ± 97 ms)
Bundle size diffs
|
4737ce1
to
6997d6d
Compare
6997d6d
to
8445652
Compare
Quality Gate passedIssues Measures |
Builds ready [8445652]
Page Load Metrics (1694 ± 100 ms)
Bundle size diffs
|
Part of #23014
Fixes #23470
Converting the level 6 dependency file
app/scripts/lib/rpc-method-middleware/handlers/log-web3-shim-usage.js
to typescript for contributing tometamask-controller.js
.Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist