chore(deps): Bump ens-controller to ^10.0.1 #24207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary purpose for upgrading this package is to ensure that we are using a version which relies on `@metamask/base-controller` v4, which protects state from being mutated accidentally and includes more type safety for messengers, among other improvements. However, this upgrade also includes theoretical support for Sepolia and Holesky ENS registries. I have not gotten ENS lookups to work on anything but Mainnet (perhaps we are explicitly targeting Mainnet somehow), but support is there should we need it. See changelog: https://github.com/MetaMask/core/blob/%40metamask/ens-controller%4010.0.1/packages/ens-controller/CHANGELOG.md
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
24 tasks
mcmire
changed the title
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/ens-controller@9.0.0 |
|
@metamaskbot update-policies |
|
Policies updated |
Builds ready [d28856f]
Page Load Metrics (1005 ± 553 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [d5da667]
Page Load Metrics (552 ± 450 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24207 +/- ##
===========================================
- Coverage 67.37% 67.36% -0.01%
===========================================
Files 1278 1286 +8
Lines 49881 50101 +220
Branches 12944 12999 +55
===========================================
+ Hits 33605 33749 +144
- Misses 16276 16352 +76 ☔ View full report in Codecov by Sentry. |
|
@metamaskbot update-policies |
|
No policy changes |
|
@metamaskbot update-policies |
|
Policies updated |
legobeat
approved these changes
Apr 25, 2024
Builds ready [7b5aedd]
Page Load Metrics (1121 ± 623 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
mikesposito
approved these changes
Apr 25, 2024
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
legobeat
approved these changes
May 4, 2024
Builds ready [01a22ab]
Page Load Metrics (1823 ± 694 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
legobeat
approved these changes
May 13, 2024
gauthierpetetin
added
the
release-12.0.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The primary purpose for upgrading this package is to ensure that we are using a version which relies on
@metamask/base-controllerv4, which protects state from being mutated accidentally and includes more type safety for messengers, among other improvements.However, this upgrade also includes theoretical support for Sepolia and Holesky ENS registries. I have not gotten ENS lookups to work on anything but Mainnet (perhaps we are explicitly targeting Mainnet somehow), but support is there should we need it.
See changelog:
https://github.com/MetaMask/core/blob/%40metamask/ens-controller%4010.0.1/packages/ens-controller/CHANGELOG.md
Related issues
Progresses #24140
Manual testing steps
There should be no functional changes in this PR, but we may want to double-check that ENS lookups still work (e.g. add an ENS name to address book or try to send a transaction to an ENS name).
Screenshots/Recordings
(None)
Pre-merge author checklist
Pre-merge reviewer checklist