-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Bump ens-controller to ^10.0.1 #24207
Conversation
The primary purpose for upgrading this package is to ensure that we are using a version which relies on `@metamask/base-controller` v4, which protects state from being mutated accidentally and includes more type safety for messengers, among other improvements. However, this upgrade also includes theoretical support for Sepolia and Holesky ENS registries. I have not gotten ENS lookups to work on anything but Mainnet (perhaps we are explicitly targeting Mainnet somehow), but support is there should we need it. See changelog: https://github.com/MetaMask/core/blob/%40metamask/ens-controller%4010.0.1/packages/ens-controller/CHANGELOG.md
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/ens-controller@9.0.0 |
@metamaskbot update-policies |
Policies updated |
Builds ready [d28856f]
Page Load Metrics (1005 ± 553 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Builds ready [d5da667]
Page Load Metrics (552 ± 450 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24207 +/- ##
===========================================
- Coverage 67.37% 67.36% -0.01%
===========================================
Files 1278 1286 +8
Lines 49881 50101 +220
Branches 12944 12999 +55
===========================================
+ Hits 33605 33749 +144
- Misses 16276 16352 +76 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@metamaskbot update-policies |
No policy changes |
@metamaskbot update-policies |
Policies updated |
Builds ready [7b5aedd]
Page Load Metrics (1121 ± 623 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Builds ready [01a22ab]
Page Load Metrics (1823 ± 694 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Description
The primary purpose for upgrading this package is to ensure that we are using a version which relies on
@metamask/base-controller
v4, which protects state from being mutated accidentally and includes more type safety for messengers, among other improvements.However, this upgrade also includes theoretical support for Sepolia and Holesky ENS registries. I have not gotten ENS lookups to work on anything but Mainnet (perhaps we are explicitly targeting Mainnet somehow), but support is there should we need it.
See changelog:
https://github.com/MetaMask/core/blob/%40metamask/ens-controller%4010.0.1/packages/ens-controller/CHANGELOG.md
Related issues
Progresses #24140
Manual testing steps
There should be no functional changes in this PR, but we may want to double-check that ENS lookups still work (e.g. add an ENS name to address book or try to send a transaction to an ENS name).
Screenshots/Recordings
(None)
Pre-merge author checklist
Pre-merge reviewer checklist