Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds "data collection for marketing" toggles #24605
feat: adds "data collection for marketing" toggles #24605
Changes from 18 commits
86cde15
288b56c
581a2ce
a91a256
1413cb8
f726ff5
2322921
a0cef9f
879d4d3
e971a28
a5b9333
3b8afb1
f739f46
cfc0c66
cf3f7c2
a353506
5b7f1a8
ddeb213
702bc6e
a798922
479d491
b2eb670
23fcc8e
94997fb
94237ce
0e46f7c
58814db
4fba09b
eaeeec7
ac58232
b147ae4
414061c
01c84d3
f8d436c
89fb6ff
73a48ce
6699dd4
f3dcaaa
000fa05
6f868d5
f74b23c
1c3cffa
53d7e47
9d2e0d1
1e05075
266127c
a4cc618
60759a8
8006556
6f7cf85
085e482
6be0d81
e27aef2
0dc9878
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for? Generally we shouldn't adding anything to this Redux slice, it's meant as a mirror of the background state. The actions here other than the background state update action are all examples of technical debt that we have not cleaned up yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to mirror the implementation of SET_PARTICIPATE_IN_METAMETRICS. We are adding the marketing toggle flag to the state as well (dataCollectionForMarketing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a misunderstanding.
SET_PARTICIPATE_IN_METAMETRICS
shouldn't be here eitherThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are good points, and these changes will be postponed for a later date given our time constraints. Both SET_PARTICIPATE_IN_METAMETRICS and SET_DATA_COLLECTION_FOR_MARKETING should be deleted from the redux state.