Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds strings for the opt in toggles #24686

Closed
wants to merge 2 commits into from

Conversation

jonybur
Copy link
Contributor

@jonybur jonybur commented May 21, 2024

This PR contains the strings for #24605

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jonybur jonybur requested a review from a team as a code owner May 21, 2024 16:11
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Member

@NidhiKJha NidhiKJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some repitition of values. Keys for these already exist in json

app/_locales/en/messages.json Show resolved Hide resolved
app/_locales/en/messages.json Show resolved Hide resolved
@jonybur jonybur closed this May 22, 2024
@jonybur
Copy link
Contributor Author

jonybur commented May 22, 2024

Can't be merged due to strings not being used

@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
@jonybur jonybur deleted the jb-opt-in-metrics-strings branch May 22, 2024 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants