Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: attribution bot 2 #24868

Closed

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented May 29, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cryptodev-2s cryptodev-2s requested review from a team and kumavis as code owners May 29, 2024 14:17
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/license-checker@26.0.1 filesystem 0 106 kB lgbot
npm/@metamask/oss-attribution-generator@2.0.2 filesystem 0 13.6 kB lgbot
npm/@metamask/spdx-compare@2.0.0 None 0 4 kB lgbot
npm/@metamask/spdx-satisfies@6.0.0 None 0 8.57 kB lgbot
npm/@npmcli/fs@2.1.2 filesystem +1 43.1 kB gar
npm/@swc/types@0.1.6 None 0 185 kB kdy1
npm/cacache@16.1.3 filesystem +8 339 kB lukekarrys
npm/deep-is@0.1.4 None 0 8.11 kB thlorenz
npm/fs-jetpack@5.1.0 filesystem 0 132 kB szwacz
npm/make-fetch-happen@10.2.1 environment, network +6 136 kB gar
npm/metamask-extension-generate-attribution@0.0.0-use.local None 0 0 B
npm/minipass-collect@1.0.2 None 0 4.87 kB isaacs
npm/minipass-fetch@2.1.2 environment, network +3 195 kB gar
npm/nopt@6.0.0 environment +1 28.7 kB gar
npm/ramda@0.18.0 None 0 595 kB davidchambers
npm/spdx-ranges@2.1.1 None 0 5.85 kB kemitchell
npm/ssri@9.0.1 None 0 37.5 kB nlf
npm/taim@1.1.0 None 0 8.05 kB rane
npm/treeify@1.1.0 None 0 22.2 kB notatestuser
npm/unique-filename@2.0.1 None +2 18 kB lukekarrys

🚮 Removed packages: npm/@sinonjs/formatio@5.0.1, npm/@swc/types@0.1.7, npm/@types/glob@7.2.0, npm/aproba@1.2.0, npm/are-we-there-yet@1.1.4, npm/bluebird@3.7.2, npm/character-entities-html4@1.1.3, npm/collapse-white-space@1.0.5, npm/consolidate@0.16.0, npm/date-now@0.1.4, npm/detect-libc@1.0.3, npm/error-inject@1.0.0, npm/gauge@2.7.4, npm/generic-names@2.0.1, npm/hash-sum@2.0.0, npm/icss-replace-symbols@1.1.0, npm/ignore-walk@3.0.1, npm/is-alphanumeric@1.0.0, npm/is-whitespace-character@1.0.3, npm/is-word-character@1.0.3, npm/markdown-escapes@1.0.3, npm/mdast-util-compact@2.0.1, npm/merge-source-map@1.1.0, npm/needle@2.4.0, npm/node-pre-gyp@0.12.0, npm/npm-bundled@1.0.6, npm/npm-packlist@1.4.1, npm/npmlog@4.1.2, npm/os-tmpdir@1.0.2, npm/osenv@0.1.5, npm/postcss-modules@4.1.3, npm/query-ast@1.0.4, npm/sass@1.69.7, npm/scss-parser@1.0.5, npm/sourcemap-codec@1.4.8, npm/state-toggle@1.0.2, npm/string-hash@1.1.3, npm/stringify-entities@3.0.1, npm/trim-trailing-lines@1.1.2, npm/trim@0.0.3, npm/unherit@1.1.2, npm/unist-util-remove-position@2.0.1, npm/vfile-location@3.2.0

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
New author npm/@npmcli/fs@2.1.2
Deprecated npm/@npmcli/move-file@2.0.1
  • Reason: This functionality has been moved to @npmcli/fs
New author npm/are-we-there-yet@3.0.1
  • orphan: npm/are-we-there-yet@3.0.1
Network access npm/make-fetch-happen@10.2.1
Network access npm/make-fetch-happen@10.2.1
Network access npm/make-fetch-happen@10.2.1
Network access npm/make-fetch-happen@10.2.1
New author npm/nopt@6.0.0
New author npm/npmlog@6.0.2
  • orphan: npm/npmlog@6.0.2
New author npm/unique-slug@3.0.0

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is a deprecated package?

The maintainer of the package marked it as deprecated. This could indicate that a single version should not be used, or that the package is no longer maintained and any new vulnerabilities will not be fixed.

Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@npmcli/fs@2.1.2
  • @SocketSecurity ignore npm/@npmcli/move-file@2.0.1
  • @SocketSecurity ignore npm/are-we-there-yet@3.0.1
  • @SocketSecurity ignore npm/make-fetch-happen@10.2.1
  • @SocketSecurity ignore npm/nopt@6.0.0
  • @SocketSecurity ignore npm/npmlog@6.0.2
  • @SocketSecurity ignore npm/unique-slug@3.0.0

@cryptodev-2s cryptodev-2s changed the title Test/attribution bot 2 test: attribution bot 2 May 29, 2024
@cryptodev-2s
Copy link
Contributor Author

@metamaskbot update-attribution

@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants