-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: filter eth request to non-EVM accounts #25003
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@metamaskbot update-policies |
Policies updated |
ui/components/multichain/app-header/app-header-unlocked-content.tsx
Outdated
Show resolved
Hide resolved
app/scripts/lib/createEvmMethodsToNonEvmAccountReqFilterMiddleware.ts
Outdated
Show resolved
Hide resolved
app/scripts/lib/createEvmMethodsToNonEvmAccountReqFilterMiddleware.ts
Outdated
Show resolved
Hide resolved
app/scripts/lib/createEvmMethodsToNonEvmAccountReqFilterMiddleware.ts
Outdated
Show resolved
Hide resolved
5e9906d
to
e101367
Compare
Sorry @k-g-j this pr wasn't up to date when you reviewed it. Whats left is just the ui changes |
Builds ready [a858d59]
Page Load Metrics (47 ± 3 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
The |
Builds ready [895ae43]
Page Load Metrics (53 ± 2 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [987a804]
Page Load Metrics (46 ± 4 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
This pr filters eth requests that goes to non evm accounts and also disables the selection of non evm accounts in the permission connect page.
Related issues
Fixes https://github.com/MetaMask/accounts-planning/issues/462
Manual testing steps
Screenshots/Recordings
Not applicable
Pre-merge author checklist
Pre-merge reviewer checklist