-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: filter eth requests for non-EVM accounts #25038
feat: filter eth requests for non-EVM accounts #25038
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
27f9ea4
to
621f65d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25038 +/- ##
===========================================
+ Coverage 65.65% 65.67% +0.03%
===========================================
Files 1376 1377 +1
Lines 54569 54576 +7
Branches 14293 14295 +2
===========================================
+ Hits 35822 35841 +19
+ Misses 18747 18735 -12 ☔ View full report in Codecov by Sentry. |
Builds ready [a843ae1]
Page Load Metrics (777 ± 1118 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
app/scripts/lib/createEvmMethodsToNonEvmAccountReqFilterMiddleware.ts
Outdated
Show resolved
Hide resolved
app/scripts/lib/createEvmMethodsToNonEvmAccountReqFilterMiddleware.ts
Outdated
Show resolved
Hide resolved
app/scripts/lib/createEvmMethodsToNonEvmAccountReqFilterMiddleware.ts
Outdated
Show resolved
Hide resolved
app/scripts/lib/createEvmMethodsToNonEvmAccountReqFilterMiddleware.ts
Outdated
Show resolved
Hide resolved
app/scripts/lib/createEvmMethodsToNonEvmAccountReqFilterMiddleware.test.ts
Outdated
Show resolved
Hide resolved
app/scripts/lib/createEvmMethodsToNonEvmAccountReqFilterMiddleware.test.ts
Outdated
Show resolved
Hide resolved
app/scripts/lib/createEvmMethodsToNonEvmAccountReqFilterMiddleware.test.ts
Outdated
Show resolved
Hide resolved
app/scripts/lib/createEvmMethodsToNonEvmAccountReqFilterMiddleware.test.ts
Outdated
Show resolved
Hide resolved
app/scripts/lib/createEvmMethodsToNonEvmAccountReqFilterMiddleware.test.ts
Show resolved
Hide resolved
Builds ready [8293cc0]
Page Load Metrics (148 ± 179 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
app/scripts/lib/createEvmMethodsToNonEvmAccountReqFilterMiddleware.test.ts
Show resolved
Hide resolved
app/scripts/lib/createEvmMethodsToNonEvmAccountReqFilterMiddleware.test.ts
Show resolved
Hide resolved
app/scripts/lib/createEvmMethodsToNonEvmAccountReqFilterMiddleware.ts
Outdated
Show resolved
Hide resolved
app/scripts/lib/createEvmMethodsToNonEvmAccountReqFilterMiddleware.ts
Outdated
Show resolved
Hide resolved
app/scripts/lib/createEvmMethodsToNonEvmAccountReqFilterMiddleware.ts
Outdated
Show resolved
Hide resolved
Builds ready [796f872]
Page Load Metrics (231 ± 265 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…quests-for-non-evm-accounts
@@ -29,6 +29,7 @@ jest.mock('@metamask-institutional/portfolio-dashboard', () => ({ | |||
})); | |||
|
|||
jest.mock('./permissions', () => ({ | |||
...jest.requireActual('./permissions'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only change here in the test. The rest was from linting.
Builds ready [c4b6c1f]
Page Load Metrics (49 ± 4 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
This PR adds a new middleware to filter EVM requests that goes to non-EVM accounts.
Related issues
Fixes https://github.com/MetaMask/accounts-planning/issues/462
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist