Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Confirmation bridge verify backend #25047

Merged
merged 27 commits into from
Jun 15, 2024
Merged

fix: Confirmation bridge verify backend #25047

merged 27 commits into from
Jun 15, 2024

Conversation

ejwessel
Copy link
Contributor

@ejwessel ejwessel commented Jun 5, 2024 •
edited by rekmarks
Loading

Description

Adds a middleware that verifies certain transactions from the Portfolio.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ejwessel
Copy link
Contributor Author

ejwessel commented Jun 5, 2024

I have read the CLA Document and I hereby sign the CLA

@ejwessel
chore: write backend confirmation
2ecd9a3 
Signed-off-by: Ethan Wessel <ethan.wessel@consensys.net>
@ejwessel
chore: remove console.log
7f10142 
Signed-off-by: Ethan Wessel <ethan.wessel@consensys.net>
@ejwessel ejwessel force-pushed the confirmation-bridge-verify-backend branch from 12231cf to 7f10142 Compare June 5, 2024 21:32
@ejwessel ejwessel changed the title Confirmation bridge verify backend Fix: confirmation bridge verify backend Jun 5, 2024
@ejwessel ejwessel changed the title Fix: confirmation bridge verify backend fix: Confirmation bridge verify backend Jun 5, 2024
ejwessel and others added 2 commits June 5, 2024 16:19
@ejwessel
chore: turn signature length into const
667ecb9 
Signed-off-by: Ethan Wessel <ethan.wessel@consensys.net>
@rekmarks
Tx verification updates (#25084)
b224935 
Commits are individually reviewable.
@rekmarks rekmarks mentioned this pull request Jun 6, 2024
Merged
micaelae
micaelae previously approved these changes Jun 6, 2024
View reviewed changes
@rekmarks @ejwessel
test: Add tx verification middleware validation tests (#25114)
c176a5b 
Adds basic validation tests for the tx verification middleware. More to
come.

---------

Signed-off-by: Ethan Wessel <ethan.wessel@consensys.net>
Co-authored-by: Ethan Wessel <ethan.wessel@consensys.net>
@ejwessel ejwessel marked this pull request as ready for review June 7, 2024 01:32
@ejwessel ejwessel requested review from a team as code owners June 7, 2024 01:32
@ejwessel ejwessel requested a review from rekmarks June 7, 2024 01:32
@ejwessel
Copy link
Contributor Author

ejwessel commented Jun 7, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

No policy changes

rekmarks and others added 2 commits June 6, 2024 23:16
@rekmarks @metamaskbot
chore: Fix lavamoat policies (#25135)
51017a1 
Fixing some LavaMoat policy conflicts.

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
@rekmarks
Merge branch 'develop' into confirmation-bridge-verify-backend
6264178
@rekmarks rekmarks force-pushed the confirmation-bridge-verify-backend branch from 6264178 to 0521b8d Compare June 7, 2024 06:20
@rekmarks rekmarks requested review from a team and kumavis as code owners June 7, 2024 06:20
@rekmarks rekmarks requested a review from micaelae June 10, 2024 23:02
matthewwalsh0
matthewwalsh0 reviewed Jun 11, 2024
View reviewed changes
app/scripts/metamask-controller.js Show resolved Hide resolved
shared/constants/bridge.ts Outdated Show resolved Hide resolved
shared/constants/bridge.ts Outdated Show resolved Hide resolved
app/scripts/lib/tx-verification/tx-verification-middleware.ts Outdated Show resolved Hide resolved
app/scripts/lib/tx-verification/tx-verification-middleware.ts Outdated Show resolved Hide resolved
app/scripts/lib/tx-verification/tx-verification-middleware.ts Show resolved Hide resolved
app/scripts/lib/tx-verification/tx-verification-middleware.ts Show resolved Hide resolved
app/scripts/lib/tx-verification/tx-verification-middleware.ts Outdated Show resolved Hide resolved
app/scripts/lib/tx-verification/tx-verification-middleware.ts Outdated Show resolved Hide resolved
app/scripts/lib/tx-verification/tx-verification-middleware.ts Outdated Show resolved Hide resolved
@MetaMask MetaMask deleted a comment from matthewwalsh0 Jun 11, 2024
matthewwalsh0
matthewwalsh0 previously approved these changes Jun 13, 2024
View reviewed changes
@metamaskbot
Copy link
Collaborator

Builds ready [06eaa70]
Page Load Metrics (51 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint701038394
domContentLoaded10211121
load41715184
domInteractive10211121
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 72.06 KiB (2.11%)
  • ui: -120.91 KiB (-1.73%)
  • common: 121.05 KiB (1.89%)

@ejwessel ejwessel merged commit 23a303d into develop Jun 15, 2024
74 checks passed
@ejwessel ejwessel deleted the confirmation-bridge-verify-backend branch June 15, 2024 00:11
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@darkwing darkwing darkwing approved these changes

@rekmarks rekmarks rekmarks approved these changes

@georgewrmarshall georgewrmarshall georgewrmarshall left review comments

@matthewwalsh0 matthewwalsh0 matthewwalsh0 left review comments

@kumavis kumavis Awaiting requested review from kumavis

@micaelae micaelae Awaiting requested review from micaelae

Assignees
No one assigned
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-bridge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ejwessel @metamaskbot @rekmarks @georgewrmarshall @darkwing @matthewwalsh0 @micaelae