-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Confirmation bridge verify backend #25047
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have read the CLA Document and I hereby sign the CLA |
Signed-off-by: Ethan Wessel <ethan.wessel@consensys.net>
Signed-off-by: Ethan Wessel <ethan.wessel@consensys.net>
ejwessel
force-pushed
the
confirmation-bridge-verify-backend
branch
from
June 5, 2024 21:32
12231cf
to
7f10142
Compare
ejwessel
changed the title
Confirmation bridge verify backend
Fix: confirmation bridge verify backend
Jun 5, 2024
ejwessel
changed the title
Fix: confirmation bridge verify backend
fix: Confirmation bridge verify backend
Jun 5, 2024
Signed-off-by: Ethan Wessel <ethan.wessel@consensys.net>
Commits are individually reviewable.
micaelae
previously approved these changes
Jun 6, 2024
Adds basic validation tests for the tx verification middleware. More to come. --------- Signed-off-by: Ethan Wessel <ethan.wessel@consensys.net> Co-authored-by: Ethan Wessel <ethan.wessel@consensys.net>
@metamaskbot update-policies |
No policy changes |
Fixing some LavaMoat policy conflicts. --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
rekmarks
force-pushed
the
confirmation-bridge-verify-backend
branch
from
June 7, 2024 06:20
6264178
to
0521b8d
Compare
Signed-off-by: Ethan Wessel <ethan.wessel@consensys.net>
Signed-off-by: Ethan Wessel <ethan.wessel@consensys.net>
matthewwalsh0
previously approved these changes
Jun 13, 2024
rekmarks
approved these changes
Jun 14, 2024
darkwing
approved these changes
Jun 14, 2024
Builds ready [06eaa70]
Page Load Metrics (51 ± 4 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
metamaskbot
added
the
release-12.1.0
Issue or pull request that will be included in release 12.1.0
label
Jun 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a middleware that verifies certain transactions from the Portfolio.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist