Tx verification updates #25084
Merged
Tx verification updates #25084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
commented
Jun 5, 2024
| @@ -1,53 +1,104 @@ | |||
| import { hashMessage } from '@ethersproject/hash'; | |||
| import { verifyMessage } from '@ethersproject/wallet'; | |||
| import type { NetworkController } from '@metamask/network-controller'; | |||
| import { rpcErrors } from '@metamask/rpc-errors'; | |||
| import { Json, JsonRpcParams, hasProperty, isObject } from '@metamask/utils'; | |||
There was a problem hiding this comment.
The JsonRpc* types from @metamask/utils are broken (they just become any in our usage).
ejwessel
force-pushed
the
rekm/tx-verification-updates
branch
from
b6f4c68
to
174ae57
Compare
ejwessel
approved these changes
Jun 5, 2024
ejwessel
merged commit b224935
into
confirmation-bridge-verify-backend
21 of 44 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #25047
Commits are individually reviewable.