fix (cherry-pick): swap+send bugs in Version v12.0.0 release

[micaelae]

Description

Related issues

Cherry pick of #25307 and #25275

Depends on #25308

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[georgewrmarshall]

Approved on behalf of @MetaMask/design-system-engineers. Not sure why we were added as code review here

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.59%. Comparing base (aba68fd) to head (d22b3b0).

❗ Current head d22b3b0 differs from pull request most recent head 71358da

Please upload reports for the commit 71358da to get more accurate results.

Additional details and impacted files

@@                 Coverage Diff                 @@
##           Version-v12.0.0   #25192      +/-   ##
===================================================
- Coverage            65.59%   65.59%   -0.01%     
===================================================
  Files                 1360     1360              
  Lines                54157    54154       -3     
  Branches             14082    14082              
===================================================
- Hits                 35524    35518       -6     
- Misses               18633    18636       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [d22b3b0]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (126 ± 145 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	74	136	90	14	7
		domContentLoaded	9	19	11	3	1
		load	46	1445	126	303	145
		domInteractive	9	19	11	3	1

Bundle size diffs [🚀 Bundle size reduced!]

• background: 22 Bytes (0.00%)
• ui: 7.16 KiB (0.11%)
• common: -3.04 KiB (-0.05%)

[metamaskbot]

No release label on PR. Adding release label release-12.0.0 on PR, as PR was added to branch 12.0.0 when release was cut.