-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (cherry-pick): swap+send bugs in Version v12.0.0 release #25192
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved on behalf of @MetaMask/design-system-engineers. Not sure why we were added as code review here
925f5b1
to
9f8825c
Compare
9f8825c
to
00b34a5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## Version-v12.0.0 #25192 +/- ##
===================================================
- Coverage 65.59% 65.59% -0.01%
===================================================
Files 1360 1360
Lines 54157 54154 -3
Branches 14082 14082
===================================================
- Hits 35524 35518 -6
- Misses 18633 18636 +3 ☔ View full report in Codecov by Sentry. |
Builds ready [d22b3b0]
Page Load Metrics (126 ± 145 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
d22b3b0
to
71358da
Compare
b57509b
to
a9f7d71
Compare
No release label on PR. Adding release label release-12.0.0 on PR, as PR was added to branch 12.0.0 when release was cut. |
Description
Related issues
Cherry pick of #25307 and #25275
Depends on #25308
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist