-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add team label to pr #25208
feat: Add team label to pr #25208
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
6d64c4c
to
ebeb46f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25208 +/- ##
========================================
Coverage 65.59% 65.59%
========================================
Files 1363 1363
Lines 54172 54172
Branches 14167 14167
========================================
Hits 35531 35531
Misses 18641 18641 ☔ View full report in Codecov by Sentry. |
Builds ready [ebeb46f]
Page Load Metrics (213 ± 230 ms)
Bundle size diffs
|
I only used it for testing
it was added to the metamask-planning repository instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good to me 🙌
Tangent question:
- I see that the
teams.json
file is not up to date (team members missing, teams not correct or people no longer in MM in the list). Is there a process to ensure that the teams file will be updated?
https://github.com/MetaMask/MetaMask-planning/blob/main/teams.json
Builds ready [fcfed70]
Page Load Metrics (139 ± 186 ms)
Bundle size diffs
|
Description
This PR adds the
add-team-label
GitHub workflow and the accompanyingadd-team-label-to-pr
script. Most of the implementation follows theadd-release-label
GitHub workflow and theadd-release-label-to-pr-and-linked-issues
script. To make the implementation easier, a new helper function,addLabelByIdToLabelable
was also added, and the previously non-exportedretrieveLabel
function was exported.When a new PR is opened, it will automatically add the author's team to the labels.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2447
Manual testing steps
Screenshots/Recordings
Not applicable
Pre-merge author checklist
Pre-merge reviewer checklist