Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add team label to pr #25208

Merged
merged 9 commits into from
Jun 14, 2024
Merged

feat: Add team label to pr #25208

merged 9 commits into from
Jun 14, 2024

Conversation

itsyoboieltr
Copy link
Contributor

@itsyoboieltr itsyoboieltr commented Jun 11, 2024

Description

Open in GitHub Codespaces

This PR adds the add-team-label GitHub workflow and the accompanying add-team-label-to-pr script. Most of the implementation follows the add-release-label GitHub workflow and the add-release-label-to-pr-and-linked-issues script. To make the implementation easier, a new helper function, addLabelByIdToLabelable was also added, and the previously non-exported retrieveLabel function was exported.

When a new PR is opened, it will automatically add the author's team to the labels.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2447

Manual testing steps

  1. Open PR, and see that the correct label is added.

Screenshots/Recordings

Not applicable

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@itsyoboieltr itsyoboieltr requested a review from a team as a code owner June 11, 2024 10:13
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@itsyoboieltr itsyoboieltr marked this pull request as draft June 11, 2024 10:13
@itsyoboieltr itsyoboieltr self-assigned this Jun 11, 2024
@itsyoboieltr itsyoboieltr marked this pull request as ready for review June 11, 2024 11:51
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.59%. Comparing base (832ae1c) to head (ebeb46f).
Report is 2 commits behind head on develop.

Current head ebeb46f differs from pull request most recent head b69d933

Please upload reports for the commit b69d933 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25208   +/-   ##
========================================
  Coverage    65.59%   65.59%           
========================================
  Files         1363     1363           
  Lines        54172    54172           
  Branches     14167    14167           
========================================
  Hits         35531    35531           
  Misses       18641    18641           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [ebeb46f]
Page Load Metrics (213 ± 230 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint72188952612
domContentLoaded8161121
load391650213479230
domInteractive8151121
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@itsyoboieltr itsyoboieltr reopened this Jun 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
I only used it for testing
it was added to the metamask-planning repository instead
Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Contributor

@seaona seaona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good to me 🙌
Tangent question:

  • I see that the teams.json file is not up to date (team members missing, teams not correct or people no longer in MM in the list). Is there a process to ensure that the teams file will be updated?

https://github.com/MetaMask/MetaMask-planning/blob/main/teams.json

@metamaskbot
Copy link
Collaborator

Builds ready [fcfed70]
Page Load Metrics (139 ± 186 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint62219893115
domContentLoaded9311242
load421823139386186
domInteractive9311242
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@itsyoboieltr itsyoboieltr merged commit 6eee01a into develop Jun 14, 2024
74 checks passed
@itsyoboieltr itsyoboieltr deleted the add-team-label-to-pr branch June 14, 2024 15:11
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants