chore: update channel for contact MMI team and CircleCI step #25247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…ask/metamask-extension into MMI-fix-slack-channel-for-mmi-team
zone-live
changed the title
legobeat
reviewed
Jun 18, 2024
playwright.config.ts
Outdated
| @@ -44,7 +43,7 @@ const config: PlaywrightTestConfig = { | |||
| trace: 'on', | |||
| video: 'off', | |||
| /* Run tests headless in local */ | |||
| headless: isHeadless('PLAYWRIGHT'), | |||
| headless: process.env.HEADLESS === 'true', | |||
There was a problem hiding this comment.
It will fail to run locally because it can't find the isHeadless. Can't find ./test/helpers/env
There was a problem hiding this comment.
There was a problem hiding this comment.
If it needs to be inlined after all, let's at least make sure API stays consistent with #24499
There was a problem hiding this comment.
Got it, let's try it out, I've approved #25388 👍🏼
There was a problem hiding this comment.
@legobeat I've re-added the isHeadless, it's working locally as well after I added the env.ts in the docker file. Thank you 👍🏼
7 tasks
Builds ready [b227755]
Page Load Metrics (126 ± 167 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25247 +/- ##
========================================
Coverage 65.38% 65.38%
========================================
Files 1382 1382
Lines 54767 54767
Branches 14368 14368
========================================
Hits 35809 35809
Misses 18958 18958 ☔ View full report in Codecov by Sentry. |
Builds ready [acb5f3d]
Page Load Metrics (53 ± 5 ms)
Bundle size diffs
|
Builds ready [13a865c]
Page Load Metrics (127 ± 176 ms)
Bundle size diffs
|
albertolive
approved these changes
Jun 19, 2024
danjm
approved these changes
Jun 20, 2024
metamaskbot
added
the
release-12.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates contact channel to be:
#contact-mmi-teamand the MMI CircleCI e2e step.Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist