-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update channel for contact MMI team and CircleCI step #25247
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…ask/metamask-extension into MMI-fix-slack-channel-for-mmi-team
playwright.config.ts
Outdated
@@ -44,7 +43,7 @@ const config: PlaywrightTestConfig = { | |||
trace: 'on', | |||
video: 'off', | |||
/* Run tests headless in local */ | |||
headless: isHeadless('PLAYWRIGHT'), | |||
headless: process.env.HEADLESS === 'true', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will fail to run locally because it can't find the isHeadless
. Can't find ./test/helpers/env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it needs to be inlined after all, let's at least make sure API stays consistent with #24499
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, let's try it out, I've approved #25388 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@legobeat I've re-added the isHeadless
, it's working locally as well after I added the env.ts
in the docker file. Thank you 👍🏼
Builds ready [b227755]
Page Load Metrics (126 ± 167 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25247 +/- ##
========================================
Coverage 65.38% 65.38%
========================================
Files 1382 1382
Lines 54767 54767
Branches 14368 14368
========================================
Hits 35809 35809
Misses 18958 18958 ☔ View full report in Codecov by Sentry. |
Builds ready [acb5f3d]
Page Load Metrics (53 ± 5 ms)
Bundle size diffs
|
Builds ready [13a865c]
Page Load Metrics (127 ± 176 ms)
Bundle size diffs
|
Description
Updates contact channel to be:
#contact-mmi-team
and the MMI CircleCI e2e step.Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist