-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(multichain): add BalancesController #25257
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
eb9972f
to
d823bf5
Compare
b43a21b
to
ba9f424
Compare
d823bf5
to
7eb60f9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25257 +/- ##
===========================================
+ Coverage 64.92% 64.99% +0.07%
===========================================
Files 1390 1392 +2
Lines 55157 55182 +25
Branches 14493 14491 -2
===========================================
+ Hits 35806 35862 +56
+ Misses 19351 19320 -31 ☔ View full report in Codecov by Sentry. |
Builds ready [ddfc3f5]
Page Load Metrics (228 ± 253 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
Builds ready [14ba8c6]
Page Load Metrics (48 ± 3 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed together, we will to adapt the subscription logic in setupMultichainDataAndSubscriptions
in another PR (for both the RatesController
and BalancesController
)
Other than that, LGTM!
Builds ready [44f3878]
Page Load Metrics (41 ± 1 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
This PR adds the Balances Controller that retrieves non EVM balances of accounts.
Related issues
Fixes https://github.com/MetaMask/accounts-planning/issues/452
Manual testing steps
This tests requires a btc account for the balances to appear in the state
state.metamask.balances
Screenshots/Recordings
Not Applicable
Pre-merge author checklist
Pre-merge reviewer checklist