feat: add custom form check alerts #25259

salimtb · 2024-06-12T15:10:13Z

Description

This PR complete the add custom network Flow

Chain Name and ChainID Match: The system should validate that the chain name provided by the user matches the corresponding network chainId. This can be done by comparing the input against a predefined list of known chain names and their associated chainIds.

Valid rpcURL: The rpcURL provided should be verified against a list of known providers. This ensures that the rpcURL is not only valid but also corresponds to a trusted source.

Unique rpcURL: The system must ensure that the rpcURL provided is not already associated with another added network within the system. This can be achieved by checking the new rpcURL against a database or list of rpcURLs already associated with existing networks.

Unique ChainID and rpcURL Combination: The combination of chainID and rpcURL should be unique and not duplicated in another existing network within the system. This requires a check against existing combinations to ensure no duplicates are allowed.

Suggest Correct Network Name and Symbol: If the network name or symbol provided does not match the expected values (based on the chainId or other validation logic), the system should suggest the correct network name and symbol. This could involve providing a dropdown list of valid names/symbols based on the chainId or implementing a correction suggestion mechanism.

Related issues

Fixes:

Manual testing steps

Run yarn && ENABLE_NETWORK_UI_REDESIGN=1 yarn start
Go to Settings -> Developer Options
Tun on the network new toggle
Go to the wallet page
Click on the network button ( see the video below )
click on add/edit network a check the acceptance criteria above

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-06-12T15:10:25Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

ui/pages/settings/networks-tab/networks-form/networks-form.js

metamaskbot · 2024-07-15T14:46:11Z

Builds ready [ca484d4]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (211 ± 210 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	67	124	98	16	8
		domContentLoaded	10	58	28	13	6
		load	44	1577	211	437	210
		domInteractive	10	58	28	13	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 4.14 KiB (0.06%)
common: 924 Bytes (0.01%)

ui/store/actions.ts

salimtb · 2024-07-16T07:27:14Z

According to our records, this URL does not match a known provider for this chain ID.

@sahar-fehri the error you're mentionning refer to an invalid rpc URL ( which mean the URL is not a node provider ).

salimtb · 2024-07-16T07:29:38Z

This looks great! 🎉

When the input RPC url is not a url like, i kinda expected to have the following error msg to appear immediately URLs require the appropriate HTTP/HTTPS prefix. But it appears only after doing input of chainId; was this intended?

Screen.Recording.2024-07-15.at.15.37.30.mov

yes this was intentional ( we have the same behavior on develop )

metamaskbot · 2024-07-16T07:53:31Z

Builds ready [857f42b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (162 ± 190 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	63	286	111	56	27
		domContentLoaded	9	82	28	18	9
		load	40	1883	162	396	190
		domInteractive	9	82	28	18	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 4.14 KiB (0.06%)
common: 924 Bytes (0.01%)

metamaskbot · 2024-07-16T09:16:59Z

Builds ready [516a62e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (237 ± 238 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	76	140	107	18	9
		domContentLoaded	9	40	20	9	4
		load	44	1744	237	495	238
		domInteractive	9	40	20	9	4

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 4.14 KiB (0.06%)
common: 784 Bytes (0.01%)

metamaskbot · 2024-07-16T14:43:32Z

Builds ready [7c6a436]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (151 ± 145 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	59	205	112	30	15
		domContentLoaded	9	61	31	15	7
		load	42	1460	151	301	145
		domInteractive	9	61	31	15	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 4.14 KiB (0.06%)
common: 784 Bytes (0.01%)

sonarcloud · 2024-07-17T08:45:20Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.2% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-07-17T10:54:39Z

Builds ready [b2f66a2]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (359 ± 329 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	65	301	113	55	26
		domContentLoaded	9	67	25	15	7
		load	39	2209	359	686	329
		domInteractive	9	67	25	15	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 4.05 KiB (0.06%)
common: 784 Bytes (0.01%)

salimtb added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 12, 2024

salimtb requested a review from a team as a code owner June 12, 2024 15:10

salimtb changed the base branch from develop to add-custom-network-modal-form June 12, 2024 15:10

metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 12, 2024

salimtb force-pushed the add-custom-form-check-alerts branch from 924e14f to 7b15964 Compare June 12, 2024 16:09

bergeron reviewed Jun 13, 2024

View reviewed changes

ui/pages/settings/networks-tab/networks-form/networks-form.js Outdated Show resolved Hide resolved

bergeron reviewed Jun 13, 2024

View reviewed changes

ui/pages/settings/networks-tab/networks-form/networks-form.js Outdated Show resolved Hide resolved

salimtb force-pushed the add-custom-network-modal-form branch 7 times, most recently from 2cb64d3 to 2db5534 Compare June 18, 2024 14:58

Base automatically changed from add-custom-network-modal-form to develop June 18, 2024 21:09

salimtb force-pushed the add-custom-form-check-alerts branch from 7b15964 to 38c38f2 Compare June 24, 2024 18:08

salimtb changed the title ~~Add custom form check alerts~~ feat: add custom form check alerts Jun 24, 2024

salimtb force-pushed the add-custom-form-check-alerts branch 2 times, most recently from 134e0c4 to e16566f Compare June 24, 2024 20:41

salimtb added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Jun 24, 2024

salimtb force-pushed the add-custom-form-check-alerts branch 4 times, most recently from 97342b5 to bf9d5bf Compare June 24, 2024 21:58

salimtb requested review from bergeron and darkwing June 24, 2024 21:59

salimtb force-pushed the add-custom-form-check-alerts branch 2 times, most recently from 54955c7 to 1e8133e Compare June 25, 2024 13:25

salimtb added 2 commits July 15, 2024 15:12

fix: remove multi-rpc drop down menu

c57af70

fix: fix unit tests

0b1b936

This comment was marked as resolved.

Sign in to view

salimtb and others added 2 commits July 15, 2024 15:49

fix: fix linter

55d5fca

Fixed swap tests

ca484d4

This comment was marked as resolved.

Sign in to view

bergeron reviewed Jul 15, 2024

View reviewed changes

ui/store/actions.ts Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

salimtb added 2 commits July 16, 2024 01:43

fix: fix comments PR

857f42b

fix: fix PR comments

516a62e

This comment was marked as resolved.

Sign in to view

salimtb added 2 commits July 16, 2024 13:57

fix PR comment

389f159

fix: fix unmatch chainId

7c6a436

bergeron previously approved these changes Jul 16, 2024

View reviewed changes

fix: fix chain list link

b2f66a2

salimtb dismissed bergeron’s stale review via b2f66a2 July 17, 2024 08:42

sahar-fehri approved these changes Jul 17, 2024

View reviewed changes

bergeron approved these changes Jul 17, 2024

View reviewed changes

salimtb merged commit 2585dcf into develop Jul 17, 2024
79 checks passed

salimtb deleted the add-custom-form-check-alerts branch July 17, 2024 16:28

github-actions bot locked and limited conversation to collaborators Jul 17, 2024

metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add custom form check alerts #25259

feat: add custom form check alerts #25259

salimtb commented Jun 12, 2024 •

edited

Loading

github-actions bot commented Jun 12, 2024

This comment was marked as resolved.

This comment was marked as resolved.

metamaskbot commented Jul 15, 2024

This comment was marked as resolved.

salimtb commented Jul 16, 2024 •

edited

Loading

salimtb commented Jul 16, 2024

metamaskbot commented Jul 16, 2024

metamaskbot commented Jul 16, 2024

This comment was marked as resolved.

metamaskbot commented Jul 16, 2024

sonarcloud bot commented Jul 17, 2024

metamaskbot commented Jul 17, 2024

feat: add custom form check alerts #25259

feat: add custom form check alerts #25259

Conversation

salimtb commented Jun 12, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jun 12, 2024

This comment was marked as resolved.

This comment was marked as resolved.

metamaskbot commented Jul 15, 2024

This comment was marked as resolved.

salimtb commented Jul 16, 2024 • edited Loading

salimtb commented Jul 16, 2024

metamaskbot commented Jul 16, 2024

metamaskbot commented Jul 16, 2024

This comment was marked as resolved.

metamaskbot commented Jul 16, 2024

sonarcloud bot commented Jul 17, 2024

Quality Gate passed

metamaskbot commented Jul 17, 2024

salimtb commented Jun 12, 2024 •

edited

Loading

salimtb commented Jul 16, 2024 •

edited

Loading