-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add custom form check alerts #25259
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
924e14f
to
7b15964
Compare
2cb64d3
to
2db5534
Compare
7b15964
to
38c38f2
Compare
134e0c4
to
e16566f
Compare
97342b5
to
bf9d5bf
Compare
54955c7
to
1e8133e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Builds ready [ca484d4]
Page Load Metrics (211 ± 210 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This comment was marked as resolved.
This comment was marked as resolved.
@sahar-fehri the error you're mentionning refer to an invalid rpc URL ( which mean the URL is not a node provider ). |
yes this was intentional ( we have the same behavior on develop ) |
Builds ready [857f42b]
Page Load Metrics (162 ± 190 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [516a62e]
Page Load Metrics (237 ± 238 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [7c6a436]
Page Load Metrics (151 ± 145 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Quality Gate passedIssues Measures |
Builds ready [b2f66a2]
Page Load Metrics (359 ± 329 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
This PR complete the add custom network Flow
Chain Name and ChainID Match: The system should validate that the chain name provided by the user matches the corresponding network chainId. This can be done by comparing the input against a predefined list of known chain names and their associated chainIds.
Valid rpcURL: The rpcURL provided should be verified against a list of known providers. This ensures that the rpcURL is not only valid but also corresponds to a trusted source.
Unique rpcURL: The system must ensure that the rpcURL provided is not already associated with another added network within the system. This can be achieved by checking the new rpcURL against a database or list of rpcURLs already associated with existing networks.
Unique ChainID and rpcURL Combination: The combination of chainID and rpcURL should be unique and not duplicated in another existing network within the system. This requires a check against existing combinations to ensure no duplicates are allowed.
Suggest Correct Network Name and Symbol: If the network name or symbol provided does not match the expected values (based on the chainId or other validation logic), the system should suggest the correct network name and symbol. This could involve providing a dropdown list of valid names/symbols based on the chainId or implementing a correction suggestion mechanism.
Related issues
Fixes:
Manual testing steps
yarn && ENABLE_NETWORK_UI_REDESIGN=1 yarn start
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist