Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: edit custom network flow #25272

Merged
merged 11 commits into from
Jun 21, 2024
Merged

feat: edit custom network flow #25272

merged 11 commits into from
Jun 21, 2024

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Jun 12, 2024

Description

Edit network flow from the modal added

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Run yarn && ENABLE_NETWORK_UI_REDESIGN=1 yarn start
  2. Go to Settings -> Developer Options
  3. Tun on the network new toggle
  4. Go to the wallet page
  5. Click on the network button ( see the video below )
  6. click on the three points button
  7. click on edit
  8. you should be able to edit a network

Screenshots/Recordings

Before

before.mov

After

after.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 12, 2024
@salimtb salimtb requested a review from a team as a code owner June 12, 2024 20:15
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 12, 2024
@salimtb salimtb changed the base branch from develop to add-custom-form-check-alerts June 12, 2024 20:24
/>
</>
);
}

AddNetworkModal.propTypes = {
isNewNetworkFlow: PropTypes.bool,
addNewNetwork: PropTypes.bool,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need comments for each of these props.

@bergeron
Copy link
Contributor

bergeron commented Jun 13, 2024

An annoying thing is how Suggested name: flashes initially before disappearing. But I think this is an existing thing that occurred before our redesign, and can be fixed later.

Screen.Recording.2024-06-13.at.3.28.13.PM.mov

bergeron
bergeron previously approved these changes Jun 18, 2024
Copy link
Contributor

@bergeron bergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving with a few suggestions

@salimtb salimtb changed the base branch from add-custom-form-check-alerts to develop June 19, 2024 22:16
@salimtb salimtb dismissed bergeron’s stale review June 19, 2024 22:16

The base branch was changed.

@salimtb salimtb changed the base branch from develop to add-custom-form-check-alerts June 19, 2024 22:16
@salimtb salimtb requested review from a team as code owners June 20, 2024 10:02
@salimtb salimtb removed request for a team and kumavis June 20, 2024 12:13
@salimtb salimtb added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Jun 20, 2024
@salimtb salimtb force-pushed the edit-custom-network-flow branch 2 times, most recently from 19ffda0 to 6d4b3ac Compare June 20, 2024 14:35
{editedNetwork ? (
<ActionableMessage
type="success"
className="home__new-tokens-imported-notification"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this class name correct? Should it be new network instead of new tokens?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because I'm using an existing CSS class; I don't want to create a new class.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 57.06806% with 82 lines in your changes missing coverage. Please review.

Project coverage is 64.93%. Comparing base (523af49) to head (667e58a).
Report is 14 commits behind head on develop.

Files Patch % Lines
.../multichain/network-list-menu/network-list-menu.js 45.16% 34 Missing ⚠️
...ttings/networks-tab/networks-form/networks-form.js 59.38% 26 Missing ⚠️
.../multichain/network-list-item/network-list-item.js 75.00% 5 Missing ⚠️
...i/pages/onboarding-flow/add-network-modal/index.js 37.50% 5 Missing ⚠️
...n/network-list-item-menu/network-list-item-menu.js 80.00% 3 Missing ⚠️
ui/ducks/app/app.ts 0.00% 3 Missing ⚠️
ui/pages/home/home.component.js 25.00% 3 Missing ⚠️
ui/pages/home/home.container.js 0.00% 2 Missing ⚠️
ui/selectors/selectors.js 66.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #25272    +/-   ##
=========================================
  Coverage    64.93%   64.93%            
=========================================
  Files         1385     1386     +1     
  Lines        54870    55010   +140     
  Branches     14408    14455    +47     
=========================================
+ Hits         35625    35717    +92     
- Misses       19245    19293    +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [667e58a]
Page Load Metrics (49 ± 5 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6410081105
domContentLoaded9211131
load40764995
domInteractive9211131
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 7.8 KiB (0.11%)
  • common: 587 Bytes (0.01%)

@EtherWizard33 EtherWizard33 self-requested a review June 21, 2024 14:29
Copy link

@EtherWizard33 EtherWizard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran the branch and looked at the code, LGTM

@salimtb salimtb merged commit 7e3b289 into develop Jun 21, 2024
74 checks passed
@salimtb salimtb deleted the edit-custom-network-flow branch June 21, 2024 14:50
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants