-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use new multichain selectors in accounts related components #25290
Merged
ccharly
merged 27 commits into
develop
from
refactor/use-multichain-selectors-in-account-components
Jun 14, 2024
Merged
refactor: use new multichain selectors in accounts related components #25290
ccharly
merged 27 commits into
develop
from
refactor/use-multichain-selectors-in-account-components
Jun 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
ccharly
force-pushed
the
refactor/use-multichain-selectors-in-account-components
branch
from
June 13, 2024 09:27
1b41d07
to
9315087
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25290 +/- ##
===========================================
+ Coverage 65.68% 65.69% +0.02%
===========================================
Files 1377 1377
Lines 54593 54624 +31
Branches 14304 14314 +10
===========================================
+ Hits 35854 35885 +31
Misses 18739 18739 ☔ View full report in Codecov by Sentry. |
Builds ready [9315087]
Page Load Metrics (201 ± 285 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
montelaidev
reviewed
Jun 13, 2024
...ponents/app/user-preferenced-currency-display/user-preferenced-currency-display.component.js
Outdated
Show resolved
Hide resolved
montelaidev
previously approved these changes
Jun 13, 2024
Builds ready [9023b7d]
Page Load Metrics (52 ± 5 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
gantunesr
reviewed
Jun 13, 2024
Co-authored-by: Gustavo Antunes <17601467+gantunesr@users.noreply.github.com>
Co-authored-by: Gustavo Antunes <17601467+gantunesr@users.noreply.github.com>
Co-authored-by: Gustavo Antunes <17601467+gantunesr@users.noreply.github.com>
gantunesr
approved these changes
Jun 13, 2024
garrettbear
approved these changes
Jun 13, 2024
Builds ready [be53a20]
Page Load Metrics (52 ± 3 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [79b91bd]
Page Load Metrics (54 ± 3 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [de1e55d]
Page Load Metrics (138 ± 180 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
matthewwalsh0
approved these changes
Jun 14, 2024
Builds ready [99d9128]
Page Load Metrics (145 ± 201 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ccharly
deleted the
refactor/use-multichain-selectors-in-account-components
branch
June 14, 2024 09:19
metamaskbot
added
the
release-12.1.0
Issue or pull request that will be included in release 12.1.0
label
Jun 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is first work of migrating some components to use the new
multichain
selectors that have been introduced for non-EVM support within the extension.None regression is expected with the introduction of those selectors.
Having a pre-PR would make future non-EVM related PRs much simpler to review too.
Related issues
Fixes:
Manual testing steps
yarn start:flask
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist