fix: flaky test Full-size View Setting @no-mmi opens the extension in popup view when opened from a dapp after enabling it in Advanced Settings
#25295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the flaky test
Full-size View Setting @no-mmi opens the extension in popup view when opened from a dapp after enabling it in Advanced Settings
.The problem is that it can take some time to load the window title, making the test fail.
Now, we've added some retry logic, to prevent such cases. See video below
This is a follow-up on @hjetpoluru 's work and investigation, so all credit to her 🙌
#25150
Related issues
Fixes: #24642
Manual testing steps
Screenshots/Recordings
See how now we enter in the retry loop and the test passes
window-title-retries.mp4
Pre-merge author checklist
Pre-merge reviewer checklist