-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Convert Swaps test from mocha to jest #25297
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
10377e6
to
0c5d23f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25297 +/- ##
===========================================
- Coverage 65.40% 64.92% -0.47%
===========================================
Files 1382 1382
Lines 54736 54736
Branches 14353 14353
===========================================
- Hits 35795 35537 -258
- Misses 18941 19199 +258 ☔ View full report in Codecov by Sentry. |
Builds ready [b7ca93e]
Page Load Metrics (957 ± 681 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM ! |
Description
This PR converts
app/scripts/controllers/swaps.test.js
from mocha to jest. In particular, replaces instances ofassert
withexpect
, and removessinon
and usesjest
's mocking capabilities in its place. Thejest.config.js
was updated to includeapp/scripts/controllers/swaps.test.js
in thetestMatch
array. The.mocharc.js
was updated to ignore the test.Related issues
Fixes: #19355
Manual testing steps
yarn jest -- app/scripts/controllers/swaps.test.js
and seeing all tests passyarn test:unit:mocha
and not seeing the metametrics tests run.Screenshots/Recordings
Not applicable
Pre-merge author checklist
Pre-merge reviewer checklist