-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: filter only EVM address when calling syncWithAddresses #25313
Merged
montelaidev
merged 3 commits into
develop
from
fix/filter-non-evm-address-to-syncWithAddresses
Jun 14, 2024
Merged
fix: filter only EVM address when calling syncWithAddresses #25313
montelaidev
merged 3 commits into
develop
from
fix/filter-non-evm-address-to-syncWithAddresses
Jun 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25313 +/- ##
===========================================
- Coverage 65.68% 65.67% -0.01%
===========================================
Files 1377 1377
Lines 54593 54593
Branches 14304 14303 -1
===========================================
- Hits 35854 35850 -4
- Misses 18739 18743 +4 ☔ View full report in Codecov by Sentry. |
Builds ready [2bb3a2a]
Page Load Metrics (50 ± 5 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ccharly
changed the title
fix: filter only evm address when calling syncWithAddresses
fix: filter only EVM address when calling syncWithAddresses
Jun 14, 2024
ccharly
reviewed
Jun 14, 2024
ccharly
approved these changes
Jun 14, 2024
Builds ready [a78087a]
Page Load Metrics (222 ± 242 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
gantunesr
approved these changes
Jun 14, 2024
metamaskbot
added
the
release-12.1.0
Issue or pull request that will be included in release 12.1.0
label
Jun 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR applies a removes all non EVM addresses prior to calling
syncWithAddresses
during_onKeyringControllerUpdate
. This is because theAccountTracker
does not support non EVM addresses. TheAccountTracker
now also subscribes toonSelectedEvmAccountChange
instead ofonSelectedAccountChange
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist