Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use a min-width value in the notifications-tag-counter #25322

Merged
merged 3 commits into from
Jun 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -383,11 +383,11 @@ exports[`App Header should match snapshot 1`] = `
style="position: relative;"
>
<div
class="mm-box notification-list-item__unread-dot__wrapper mm-box--padding-top-0 mm-box--padding-right-0 mm-box--padding-bottom-0 mm-box--padding-left-0 mm-box--display-block mm-box--background-color-error-default mm-box--rounded-md mm-box--border-style-none"
class="mm-box notification-list-item__unread-dot__wrapper mm-box--padding-top-0 mm-box--padding-right-0 mm-box--padding-bottom-0 mm-box--padding-left-0 mm-box--display-block mm-box--background-color-error-default mm-box--rounded-lg mm-box--border-style-none"
style="position: absolute; cursor: pointer; top: -5px; left: 10px; z-index: 1;"
>
<p
class="mm-box mm-text notifications-tag-counter__unread-dot mm-text--body-xs mm-box--color-error-inverse"
class="mm-box mm-text notifications-tag-counter__unread-dot mm-text--body-xs mm-text--text-align-center mm-box--color-error-inverse"
>
1
</p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,12 @@
padding-left: 6px;
padding-right: 6px;

&__text {
min-width: 13px;
Prithpal-Sooriya marked this conversation as resolved.
Show resolved Hide resolved
}

&__unread-dot {
min-width: 16.5px;
padding-left: 3px;
padding-right: 3px;
line-height: 1.4;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
Display,
TextColor,
TextVariant,
TextAlign,
} from '../../../helpers/constants/design-system';

type NotificationsTagCounterProps = {
Expand Down Expand Up @@ -37,7 +38,7 @@ export const NotificationsTagCounter = ({
}}
backgroundColor={BackgroundColor.errorDefault}
borderStyle={BorderStyle.none}
borderRadius={BorderRadius.MD}
borderRadius={BorderRadius.LG}
paddingTop={0}
paddingBottom={0}
paddingLeft={0}
Expand All @@ -47,6 +48,7 @@ export const NotificationsTagCounter = ({
color={TextColor.errorInverse}
variant={TextVariant.bodyXs}
className="notifications-tag-counter__unread-dot"
textAlign={TextAlign.Center}
>
{notificationsCount > 10 ? '9+' : notificationsCount}
</Text>
Expand All @@ -58,7 +60,7 @@ export const NotificationsTagCounter = ({
<Box
backgroundColor={BackgroundColor.errorDefault}
borderStyle={BorderStyle.none}
borderRadius={BorderRadius.MD}
borderRadius={BorderRadius.LG}
paddingTop={0}
paddingBottom={0}
className="notifications-tag-counter"
Expand All @@ -67,6 +69,8 @@ export const NotificationsTagCounter = ({
color={TextColor.errorInverse}
variant={TextVariant.bodySm}
data-testid="global-menu-notification-count"
className="notifications-tag-counter__text"
textAlign={TextAlign.Center}
>
{notificationsCount > 10 ? '9+' : notificationsCount}
</Text>
Expand Down