Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp build notifications #25332

Closed
wants to merge 9 commits into from

Commits on Jun 14, 2024

  1. fix: notification detail network fee broke application (#25315)

    <!--
    Please submit this PR as a draft initially.
    Do not mark it as "Ready for review" until the template has been
    completely filled out, and PR status checks have passed at least once.
    -->
    
    ## **Description**
    
    Yeah, due to some type assertions (evil), we did not receive a correct
    value expected. Due to this we ended up performing a `.split` on an
    undefined... then crash.
    
    This adds some safer logic and also fixes the area that call the
    function with the wrong inputs.
    
    A separate PR will be ready that fixes these bad type assertions.
    
    <!--
    Write a short description of the changes included in this pull request,
    also include relevant motivation and context. Have in mind the following
    questions:
    1. What is the reason for the change?
    2. What is the improvement/solution?
    -->
    
    [![Open in GitHub
    Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25315?quickstart=1)
    
    ## **Related issues**
    
    Fixes:
    
    ## **Manual testing steps**
    
    1. Create a MATIC send/receive notification
    2. Open details
    3. See crash
    
    ## **Screenshots/Recordings**
    
    
    ![image](https://github.com/MetaMask/metamask-extension/assets/17534261/4f4bb77d-dabd-4226-983a-b6d6ff2bb6b5)
    
    
    <!-- If applicable, add screenshots and/or recordings to visualize the
    before and after of your change. -->
    
    ### **Before**
    
    <!-- [screenshots/recordings] -->
    
    ### **After**
    
    <!-- [screenshots/recordings] -->
    
    ## **Pre-merge author checklist**
    
    - [x] I've followed [MetaMask Contributor
    Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
    Extension Coding
    Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
    - [x] I've completed the PR template to the best of my ability
    - [x] I’ve included tests if applicable
    - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [x] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    
    ## **Pre-merge reviewer checklist**
    
    - [ ] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [ ] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    Prithpal-Sooriya committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    5d2dd45 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f723ab7 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Merge branch 'Version-v12.0.0' of github.com:MetaMask/metamask-extens…

    …ion into temp-build-notifications
    Prithpal-Sooriya committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    309fd51 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    78ad2e3 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Merge branch 'Version-v12.0.0' of github.com:MetaMask/metamask-extens…

    …ion into temp-build-notifications
    Prithpal-Sooriya committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    2012f83 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Merge branch 'Version-v12.0.0' of github.com:MetaMask/metamask-extens…

    …ion into temp-build-notifications
    Prithpal-Sooriya committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    2e73e71 View commit details
    Browse the repository at this point in the history
  2. fix changelog

    Prithpal-Sooriya committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    c69d3b5 View commit details
    Browse the repository at this point in the history
  3. revert date change

    Prithpal-Sooriya committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    8af0d5a View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Merge branch 'Version-v12.0.0' of github.com:MetaMask/metamask-extens…

    …ion into temp-build-notifications
    Prithpal-Sooriya committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    42215ec View commit details
    Browse the repository at this point in the history