-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add e2e for scenario where wallet_switchEthereumChain
call is canceled with other confirmations queued behind it
#25341
Conversation
…d with other confirmations queued behind it
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
wallet_switchEthereumChain
call is canceled with other confirmations queued behind it
@@ -165,4 +165,158 @@ describe('Request Queuing Dapp 1, Switch Tx -> Dapp 2 Send Tx', function () { | |||
}, | |||
); | |||
}); | |||
|
|||
it('should queue send tx after switch network confirmation and transaction should target the correct network after switch is cancelled.', async function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be helpful if there were a comment above this describing that the original bug was noticed on https://app.odos.xyz/, describing the manual procedure for reproducing, and pointing to the PRs that fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test is covering a different scenario from the eth_requestAccount
requests not being passed through that you discovered with ODOS
Instead see: #25310
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25341 +/- ##
========================================
Coverage 64.93% 64.93%
========================================
Files 1385 1385
Lines 54958 54958
Branches 14421 14421
========================================
Hits 35682 35682
Misses 19276 19276 ☔ View full report in Codecov by Sentry. |
Builds ready [12baa92]
Page Load Metrics (232 ± 267 ms)
Bundle size diffs
|
Builds ready [ffe44f1]
Page Load Metrics (46 ± 5 ms)
Bundle size diffs
|
Description
Add an e2e to catch regressions similar to the bug identified in this patch/cherry-pick fix to the v12.0.0 RC branch
We had an e2e for a similar flow but where the
wallet_switchEthereumChain
confirmation was confirmed rather than cancelled. The bug occurred when the confirmation was cancelled and so this test handles that case.Related issues
See: https://consensys.slack.com/archives/CTQAGKY5V/p1718385169900809?thread_ts=1718140104.578969&cid=CTQAGKY5V
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist