-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: re-add patch to nonce-tracker that was incorrectly removed #25342
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
All transactions, including swaps, are created with the correct nonce and can be successfully submitted on BNB and mainnet. bnbFix.movCurrent PR also resolves the issue with Sepolia 0 nonce: sepoliaFix.mov |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25342 +/- ##
========================================
Coverage 65.37% 65.37%
========================================
Files 1377 1377
Lines 54623 54623
Branches 14320 14320
========================================
Hits 35709 35709
Misses 18914 18914 ☔ View full report in Codecov by Sentry. |
Builds ready [73de7d7]
Page Load Metrics (46 ± 3 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Missing release label release-12.0.0 on PR. Adding release label release-12.0.0 on PR and removing other release labels(release-12.1.0), as PR was cherry-picked in branch 12.0.0. |
Note
This PR will fix a release blocker in
v12.0.0
and will be cherry-picked there once it has been merged here.Description
This PR re-adds a patch to nonce-tracker that was incorrectly removed.
For reference, here is the original patch that was incorrectly removed.
Here is the patch in this PR.
sendAsync
method of the provider.v12
anddevelop
, and has been causing issues (see below).Long Term Fix
The Wallet API and Transactions teams are discussing a long-term fix.
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist