Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-add patch to nonce-tracker that was incorrectly removed #25342

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

dbrans
Copy link
Contributor

@dbrans dbrans commented Jun 14, 2024

Note

This PR will fix a release blocker in v12.0.0 and will be cherry-picked there once it has been merged here.

Description

This PR re-adds a patch to nonce-tracker that was incorrectly removed.

For reference, here is the original patch that was incorrectly removed.

Here is the patch in this PR.

Long Term Fix

The Wallet API and Transactions teams are discussing a long-term fix.

Open in GitHub Codespaces

Related issues

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dbrans dbrans added the team-transactions Transactions team label Jun 14, 2024
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jun 14, 2024
@dbrans dbrans marked this pull request as ready for review June 14, 2024 21:53
@dbrans dbrans requested a review from a team as a code owner June 14, 2024 21:53
@sleepytanya
Copy link
Contributor

All transactions, including swaps, are created with the correct nonce and can be successfully submitted on BNB and mainnet.

bnbFix.mov

Current PR also resolves the issue with Sepolia 0 nonce:

sepoliaFix.mov

@dbrans dbrans changed the title fix: re-add patch to nonce-tracker which was unintentionally removed fix: re-add patch to nonce-tracker that was incorrectly removed Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.37%. Comparing base (2aaf565) to head (73de7d7).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25342   +/-   ##
========================================
  Coverage    65.37%   65.37%           
========================================
  Files         1377     1377           
  Lines        54623    54623           
  Branches     14320    14320           
========================================
  Hits         35709    35709           
  Misses       18914    18914           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [73de7d7]
Page Load Metrics (46 ± 3 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint61917684
domContentLoaded9221132
load38604663
domInteractive9221132
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -17 Bytes (-0.00%)

@dbrans dbrans merged commit 8b764fa into develop Jun 15, 2024
108 checks passed
@dbrans dbrans deleted the dbrans/nonce-tracker-patch branch June 15, 2024 00:51
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2024
@metamaskbot metamaskbot added release-12.1.0 Issue or pull request that will be included in release 12.1.0 release-12.0.0 Issue or pull request that will be included in release 12.0.0 and removed release-12.1.0 Issue or pull request that will be included in release 12.1.0 labels Jun 15, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.0.0 on PR. Adding release label release-12.0.0 on PR and removing other release labels(release-12.1.0), as PR was cherry-picked in branch 12.0.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-confirmations Push issues to confirmations team team-transactions Transactions team
Projects
None yet
4 participants