fix: Preventing a routechange to the Metametrics Onboarding page on wallet creation

[vthomas13]

Description

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/87368/workflows/69e4b630-e6bd-4f75-a4ed-b95c3f52708d/jobs/3197847/tests
This PR aims to fix the flakiness in tests that get stuck at the password creation screen. This problem & solution is similar to #24874

Related issues

Fixes: TimeoutError: Waiting for element to be located By(css selector, [data-testid="create-password-new"])

Manual testing steps

1. Run the test "Clicks create a new wallet, accepts a secure password, reveals the Secret Recovery Phrase, confirm SRP"
2. Confirm that the test does not fail because of that reroute

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[DDDDDanica]

LGTM, Nice fix !

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.02%. Comparing base (8e48bee) to head (de0afac).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #25344   +/-   ##
========================================
  Coverage    65.02%   65.02%           
========================================
  Files         1391     1391           
  Lines        55182    55184    +2     
  Branches     14499    14499           
========================================
+ Hits         35879    35881    +2     
  Misses       19303    19303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chloeYue]

LGTM!

[metamaskbot]

Builds ready [de0afac]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (47 ± 3 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	102	79	8	4
		domContentLoaded	8	26	11	4	2
		load	40	71	47	7	3
		domInteractive	8	26	11	4	2

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 37 Bytes (0.00%)
• common: 0 Bytes (0.00%)