-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Preventing a routechange to the Metametrics Onboarding page on wallet creation #25344
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
0ca49c1
to
80a9970
Compare
80a9970
to
de0afac
Compare
LGTM, Nice fix ! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25344 +/- ##
========================================
Coverage 65.02% 65.02%
========================================
Files 1391 1391
Lines 55182 55184 +2
Branches 14499 14499
========================================
+ Hits 35879 35881 +2
Misses 19303 19303 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Builds ready [de0afac]
Page Load Metrics (47 ± 3 ms)
Bundle size diffs
|
Description
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/87368/workflows/69e4b630-e6bd-4f75-a4ed-b95c3f52708d/jobs/3197847/tests
This PR aims to fix the flakiness in tests that get stuck at the password creation screen. This problem & solution is similar to #24874
Related issues
Fixes:
TimeoutError: Waiting for element to be located By(css selector, [data-testid="create-password-new"])
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist