-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hide mark all as read button with no uread notifications #25348
Merged
matteoscurati
merged 7 commits into
develop
from
fix/hide-button-with-no-uread-notifications
Jun 18, 2024
Merged
fix: hide mark all as read button with no uread notifications #25348
matteoscurati
merged 7 commits into
develop
from
fix/hide-button-with-no-uread-notifications
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Prithpal-Sooriya
previously approved these changes
Jun 18, 2024
dovydas55
previously approved these changes
Jun 18, 2024
matteoscurati
changed the title
Fix: hide mark all as read button with no uread notifications
fix: hide mark all as read button with no uread notifications
Jun 18, 2024
matteoscurati
dismissed stale reviews from Prithpal-Sooriya and dovydas55
via
June 18, 2024 12:08
fda8a63
Prithpal-Sooriya
approved these changes
Jun 18, 2024
dovydas55
approved these changes
Jun 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25348 +/- ##
========================================
Coverage 65.38% 65.38%
========================================
Files 1382 1382
Lines 54765 54767 +2
Branches 14367 14368 +1
========================================
+ Hits 35807 35809 +2
Misses 18958 18958 ☔ View full report in Codecov by Sentry. |
metamaskbot
added
the
release-12.1.0
Issue or pull request that will be included in release 12.1.0
label
Jun 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.1.0
Issue or pull request that will be included in release 12.1.0
team-notifications
Notifications team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a small fix to hide the "Mark all as read" button for notifications when all notifications are already read.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist