Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide mark all as read button with no uread notifications #25348

Merged
merged 7 commits into from
Jun 18, 2024

Conversation

matteoscurati
Copy link
Contributor

@matteoscurati matteoscurati commented Jun 15, 2024

Description

This PR introduces a small fix to hide the "Mark all as read" button for notifications when all notifications are already read.
Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matteoscurati matteoscurati added the team-notifications Notifications team label Jun 15, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@matteoscurati matteoscurati marked this pull request as ready for review June 15, 2024 04:14
@matteoscurati matteoscurati requested a review from a team as a code owner June 15, 2024 04:14
dovydas55
dovydas55 previously approved these changes Jun 18, 2024
@matteoscurati matteoscurati changed the title Fix: hide mark all as read button with no uread notifications fix: hide mark all as read button with no uread notifications Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.38%. Comparing base (85783b1) to head (f2f17b5).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25348   +/-   ##
========================================
  Coverage    65.38%   65.38%           
========================================
  Files         1382     1382           
  Lines        54765    54767    +2     
  Branches     14367    14368    +1     
========================================
+ Hits         35807    35809    +2     
  Misses       18958    18958           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matteoscurati matteoscurati merged commit 40c0f02 into develop Jun 18, 2024
73 checks passed
@matteoscurati matteoscurati deleted the fix/hide-button-with-no-uread-notifications branch June 18, 2024 22:04
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-notifications Notifications team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants