Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logic for using notifications tabs #25350

Merged

Conversation

matteoscurati
Copy link
Contributor

@matteoscurati matteoscurati commented Jun 15, 2024

Description

This PR introduces two small fixes:

  • If there are no snaps with notifications, the tabs for filtering results are not displayed on the notifications page.
  • Feature announcements are included in the onChain tab and not in the Web3 tab.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matteoscurati matteoscurati added the team-notifications Notifications team label Jun 15, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

codecov bot commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.41%. Comparing base (ed06176) to head (0cfaf8f).
Report is 1 commits behind head on develop.

Files Patch % Lines
ui/pages/notifications/notifications.tsx 33.33% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #25350      +/-   ##
===========================================
- Coverage    65.42%   65.41%   -0.01%     
===========================================
  Files         1380     1380              
  Lines        54688    54691       +3     
  Branches     14339    14341       +2     
===========================================
- Hits         35776    35774       -2     
- Misses       18912    18917       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [4a72bf8]
Page Load Metrics (40 ± 1 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint60836873
domContentLoaded810910
load37464031
domInteractive810910
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 72 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@matteoscurati matteoscurati marked this pull request as ready for review June 15, 2024 05:49
@matteoscurati matteoscurati requested a review from a team as a code owner June 15, 2024 05:49
@metamaskbot
Copy link
Collaborator

Builds ready [53b7997]
Page Load Metrics (124 ± 155 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint631058094
domContentLoaded9131111
load391532124323155
domInteractive9131111
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 72 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [0cfaf8f]
Page Load Metrics (41 ± 2 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint60158782412
domContentLoaded813911
load38504132
domInteractive813911
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 72 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@matteoscurati matteoscurati merged commit 7e03b4d into develop Jun 18, 2024
74 checks passed
@matteoscurati matteoscurati deleted the fix/no-multi-columnr-list-when-no-snaps-installed branch June 18, 2024 12:06
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-notifications Notifications team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants