-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(25335): fix flaky test "Unlock wallet should send first three Page metric events upon fullscreen page load" #25351
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…e metric events upon fullscreen page load"
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25351 +/- ##
========================================
Coverage 65.68% 65.68%
========================================
Files 1377 1377
Lines 54623 54623
Branches 14320 14320
========================================
Hits 35879 35879
Misses 18744 18744 ☔ View full report in Codecov by Sentry. |
Builds ready [1127308]
Page Load Metrics (383 ± 306 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 😍
Description
The flakyness comes from unordered events from time to time.
Based on the log of events when unlock wallet:
The
events
array is not sorted, and there is nothing wrong with metrics itself and the order of sending, which can be validated bytimestamp
.Therefore the fix is to order events by
timestamp
and assert the value.Related issues
Fixes: #25335
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist