Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump Firefox outdated browser version #25365

Merged
merged 1 commit into from
Jun 24, 2024
Merged

chore: Bump Firefox outdated browser version #25365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ui/helpers/constants/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,10 @@ export const OUTDATED_BROWSER_VERSIONS = {
// or the earliest version that supports our MV3 functionality, whichever is higher
chrome: '<109',
edge: '<109',
// Firefox should match the most recent end-of-life extended support release
firefox: '<91',
// Firefox should match the previous extended support release
// Current ESR: 115
// Previous ESR: 102
firefox: '<102',
// Opera versions correspond to differently numbered Chromium versions.
// Opera should be set to the equivalent of the Chromium version set
// Opera 95 is based on Chromium 109
Expand Down
4 changes: 2 additions & 2 deletions ui/helpers/utils/util.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,14 +218,14 @@ describe('util', () => {
});
it('should return false when given a modern firefox browser', () => {
const browser = Bowser.getParser(
'Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/91.0',
'Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/102.0',
);
const result = util.getIsBrowserDeprecated(browser);
expect(result).toStrictEqual(false);
});
it('should return true when given an outdated firefox browser', () => {
const browser = Bowser.getParser(
'Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:75.0) Gecko/20100101 Firefox/90.0',
'Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:75.0) Gecko/20100101 Firefox/91.0',
);
const result = util.getIsBrowserDeprecated(browser);
expect(result).toStrictEqual(true);
Expand Down