Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint errors on commit 5892d7cdc #25367

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Jun 17, 2024

Fixes lint errors and e2e failures on v11.16.12, which would have been introduced during conflict resolution when cherry-picking #24605

Specifically:

  • test/e2e/default-fixture.js is deleted as that file does not exist on master yet and is not used. However, importantly, the change made in test/e2e/default-fixture.js in feat: adds "data collection for marketing" toggles #24605 is now applied to test/e2e/fixture-builder.js (this was needed for e2e tests to pass)
  • delete ui/pages/settings/security-tab/metametrics-toggle/metametrics-toggle.tsx and the associated test file, as these seem to be unused
  • delete unused variables in ui/pages/settings/security-tab/security-tab.component.js

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (Version-v11.16.12@c6dbd72). Learn more about missing BASE report.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             Version-v11.16.12   #25367   +/-   ##
====================================================
  Coverage                     ?   67.30%           
====================================================
  Files                        ?     1266           
  Lines                        ?    49744           
  Branches                     ?    12924           
====================================================
  Hits                         ?    33477           
  Misses                       ?    16267           
  Partials                     ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danjm danjm marked this pull request as ready for review June 17, 2024 19:47
@danjm danjm requested a review from a team as a code owner June 17, 2024 19:47
@danjm danjm merged commit 3e8ce07 into Version-v11.16.12 Jun 17, 2024
70 of 71 checks passed
@danjm danjm deleted the fix-v11.16.12-following-5892d7cdc branch June 17, 2024 19:51
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [c9a7892]
Page Load Metrics (322 ± 295 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint681601022211
domContentLoaded10422194
load462227322614295
domInteractive10422194

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants