-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: capturing primaryType of typed signature messages in metrics #25384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpuri
added
confirmation-redesign
team-confirmations
Push issues to confirmations team
labels
Jun 18, 2024
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
matthewwalsh0
previously approved these changes
Jun 18, 2024
…-extension into types_sign_metrics_fix
Builds ready [c73d7c5]
Page Load Metrics (52 ± 5 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25384 +/- ##
========================================
Coverage 65.39% 65.39%
========================================
Files 1382 1382
Lines 54764 54764
Branches 14369 14370 +1
========================================
+ Hits 35809 35810 +1
+ Misses 18955 18954 -1 ☔ View full report in Codecov by Sentry. |
matthewwalsh0
approved these changes
Jun 20, 2024
OGPoyraz
approved these changes
Jun 21, 2024
metamaskbot
added
the
release-12.1.0
Issue or pull request that will be included in release 12.1.0
label
Jun 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
confirmation-redesign
release-12.1.0
Issue or pull request that will be included in release 12.1.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
capturing primaryType of typed signature messages in metrics
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2652
Manual testing steps
Screenshots/Recordings
NA
Pre-merge author checklist
Pre-merge reviewer checklist