Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: capturing primaryType of typed signature messages in metrics #25384

Merged
merged 7 commits into from
Jun 21, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jun 18, 2024

Description

capturing primaryType of typed signature messages in metrics

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2652

Manual testing steps

  1. Enable metrics locally
  2. Go to test dapp
  3. Submit typed signature and check metrics

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added confirmation-redesign team-confirmations Push issues to confirmations team labels Jun 18, 2024
@jpuri jpuri requested a review from a team as a code owner June 18, 2024 12:37
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

matthewwalsh0
matthewwalsh0 previously approved these changes Jun 18, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [c73d7c5]
Page Load Metrics (52 ± 5 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6910684116
domContentLoaded9231231
load407752105
domInteractive9231231
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 24 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.39%. Comparing base (2115516) to head (c73d7c5).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25384   +/-   ##
========================================
  Coverage    65.39%   65.39%           
========================================
  Files         1382     1382           
  Lines        54764    54764           
  Branches     14369    14370    +1     
========================================
+ Hits         35809    35810    +1     
+ Misses       18955    18954    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuri jpuri requested a review from matthewwalsh0 June 20, 2024 12:44
@jpuri jpuri merged commit 99a1df7 into develop Jun 21, 2024
74 checks passed
@jpuri jpuri deleted the types_sign_metrics_fix branch June 21, 2024 11:45
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
confirmation-redesign release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants