Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix isHeadless usage in MMI Dockerfile #25388

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Jun 18, 2024

Description

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat changed the title Mmi fix slack channel for mmi team fix isHeadless tests Jun 18, 2024
@legobeat legobeat changed the title fix isHeadless tests fix isHeadless usage in MMI Dockerfile Jun 18, 2024
@legobeat legobeat requested a review from zone-live June 18, 2024 14:33
@legobeat legobeat force-pushed the MMI-fix-slack-channel-for-mmi-team branch from b2d28cf to 5c9c4d4 Compare June 18, 2024 14:54
@legobeat legobeat force-pushed the MMI-fix-slack-channel-for-mmi-team branch from 5c9c4d4 to e65c622 Compare June 18, 2024 16:22
@zone-live
Copy link
Contributor

@legobeat I've added these changes in my PR as well. Feel free to close this one 👍🏼

@zone-live zone-live deleted the branch MetaMask:MMI-fix-slack-channel-for-mmi-team June 20, 2024 13:02
@zone-live zone-live closed this Jun 20, 2024
@legobeat legobeat deleted the MMI-fix-slack-channel-for-mmi-team branch June 20, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants