-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Tooltip
Snap custom UI component
#25413
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
content: mapToTemplate({ | ||
element: | ||
typeof element.props.content === 'string' | ||
? Text({ children: element.props.content }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrapped the content
prop with the Text
element to be able to pass it directly to the propComponents
section. This reduces the bloat of having a logic to pass it somewhere else if it's a string. Furthermore we keep a consistent styling.
289e204
to
f507c37
Compare
e39f5d0
to
3065f26
Compare
ui/components/app/metamask-template-renderer/safe-component-list.js
Outdated
Show resolved
Hide resolved
641e2a6
to
b7f7951
Compare
Description
This adds the new
Tooltip
component to the Snap custom UI renderer.Related issues
Fixes: #25385
Manual testing steps
Show JSX dialog
.Count
text.Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist