Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add SonarCloud scan job #25421

Merged
merged 3 commits into from
Jun 28, 2024
Merged

ci: add SonarCloud scan job #25421

merged 3 commits into from
Jun 28, 2024

Conversation

jvbriones
Copy link
Contributor

@jvbriones jvbriones commented Jun 19, 2024

Description

Add a SonarCloud scan job

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jun 19, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 19, 2024
@jvbriones jvbriones changed the title chore: add SonarCloud scan CI: add SonarCloud scan Jun 19, 2024
@jvbriones jvbriones changed the title CI: add SonarCloud scan ci: add SonarCloud scan Jun 19, 2024
@jvbriones jvbriones self-assigned this Jun 19, 2024
@jvbriones
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@jvbriones jvbriones changed the title ci: add SonarCloud scan ci: add SonarCloud scan job Jun 19, 2024
@jvbriones jvbriones marked this pull request as ready for review June 20, 2024 15:10
@jvbriones jvbriones requested a review from a team as a code owner June 20, 2024 15:10
Copy link

sonarcloud bot commented Jun 28, 2024

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.65%. Comparing base (574f819) to head (9a90e14).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25421   +/-   ##
========================================
  Coverage    69.65%   69.65%           
========================================
  Files         1355     1355           
  Lines        48007    48007           
  Branches     13235    13235           
========================================
  Hits         33437    33437           
  Misses       14570    14570           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [9a90e14]
Page Load Metrics (264 ± 258 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint633091285024
domContentLoaded996392210
load412147264538258
domInteractive996392210
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jvbriones jvbriones merged commit 1661b21 into develop Jun 28, 2024
72 checks passed
@jvbriones jvbriones deleted the chore-sonar-scan branch June 28, 2024 13:55
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-unkown
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants