Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new useMultichainSelector #25423

Merged
merged 18 commits into from
Jun 25, 2024
Merged

Conversation

montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Jun 19, 2024

Description

This PR introduces useMultichainSelector to pass an additional account arg when using certain multichain selectors.

Related issues

Fixes https://github.com/MetaMask/accounts-planning/issues/495

Manual testing steps

This PR only adds selectors and they are not currently used on the extension. It will setup the following PR #25437

Screenshots/Recordings

No UI/UX changes

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@montelaidev montelaidev changed the title Feat/use multichian selector Feat/use multichain selector Jun 19, 2024
@montelaidev montelaidev changed the title Feat/use multichain selector feat: add new useMultichainSelector Jun 19, 2024
@montelaidev montelaidev self-assigned this Jun 19, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.

Project coverage is 69.61%. Comparing base (18ebe12) to head (18ad338).
Report is 5 commits behind head on develop.

Files Patch % Lines
ui/selectors/multichain.ts 73.68% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #25423      +/-   ##
===========================================
- Coverage    69.62%   69.61%   -0.00%     
===========================================
  Files         1344     1345       +1     
  Lines        47795    47804       +9     
  Branches     13190    13193       +3     
===========================================
+ Hits         33273    33277       +4     
- Misses       14522    14527       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [ded9ae7]
Page Load Metrics (139 ± 182 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint65232913517
domContentLoaded9251242
load411787139378182
domInteractive9251242
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 371 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@montelaidev montelaidev marked this pull request as ready for review June 20, 2024 15:12
@montelaidev montelaidev requested a review from a team as a code owner June 20, 2024 15:12
@metamaskbot
Copy link
Collaborator

Builds ready [6ac4037]
Page Load Metrics (47 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6310479105
domContentLoaded9221131
load40694784
domInteractive9221131
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 371 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

ui/selectors/accounts.test.ts Outdated Show resolved Hide resolved
ui/selectors/multichain.ts Outdated Show resolved Hide resolved
ui/selectors/multichain.ts Outdated Show resolved Hide resolved
ui/hooks/useMultichainSelector.test.ts Outdated Show resolved Hide resolved
ui/hooks/useMultichainSelector.test.ts Show resolved Hide resolved
ui/selectors/accounts.ts Outdated Show resolved Hide resolved
ui/selectors/accounts.test.ts Outdated Show resolved Hide resolved
ui/selectors/accounts.ts Outdated Show resolved Hide resolved
ui/selectors/multichain.ts Outdated Show resolved Hide resolved
ui/selectors/multichain.ts Outdated Show resolved Hide resolved
@metamaskbot
Copy link
Collaborator

Builds ready [7070665]
Page Load Metrics (56 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint721049095
domContentLoaded9241232
load45795694
domInteractive9241232
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 229 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

ui/selectors/multichain.ts Outdated Show resolved Hide resolved
ui/selectors/multichain.ts Outdated Show resolved Hide resolved
ccharly
ccharly previously approved these changes Jun 24, 2024
@gantunesr gantunesr removed the request for review from k-g-j June 24, 2024 19:08
@gantunesr gantunesr merged commit 130b9b0 into develop Jun 25, 2024
72 of 73 checks passed
@gantunesr gantunesr deleted the feat/use-multichian-selector branch June 25, 2024 00:01
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 25, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [18ad338]
Page Load Metrics (45 ± 5 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint681027884
domContentLoaded9111010
load408545105
domInteractive9111010
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 229 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants