-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: UX: Multichain: Fix dead network problem when switching tabs #25425
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
050bfe1
to
5599672
Compare
dfea637
to
4635c11
Compare
When trying to send a transaction on a network with dead RPC, I see 2 RPC calls that each take ~5 seconds to fail, which together cause the ~10 second delay in receiving the metamask popup:
I don't know why the RPC queries take 5 seconds instead of failing fast. Perhaps somewhere lower level is doing retry. But that's the only code I see slowing down the popup. Screen.Recording.2024-06-27.at.2.21.48.PM.mov |
on the test environment I am seeing a great amount of requests for mostly testing-env-dead-network.mp4and on the dev build from this branch, I am seeing a similar behaviour as I see in production: sometimes the popup is open fast, but sometimes it takes ~5 seconds multichain-broken-network-branch.mp4 |
4635c11
to
d0f7275
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25425 +/- ##
===========================================
- Coverage 69.57% 69.56% -0.01%
===========================================
Files 1360 1360
Lines 48172 48177 +5
Branches 13296 13296
===========================================
Hits 33513 33513
- Misses 14659 14664 +5 ☔ View full report in Codecov by Sentry. |
Builds ready [84786eb]
Page Load Metrics (263 ± 280 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Missing release label release-12.0.0 on PR. Adding release label release-12.0.0 on PR and removing other release labels(release-12.2.0), as PR was cherry-picked in branch 12.0.0. |
Description
This PR ensures that a connection to a given network does not block the UI when switching to a dapp tab that remembers that down network, thus preventing a non-respondent network from not displaying the MetaMask UI
Related issues
Fixes: #25588
Manual testing steps
Scenario 1: Kill network, manually click MetaMask extension icon
Scenario 2: Kill network, trigger transaction from dapp
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist