-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update Beta build configuration #25430
Conversation
The Beta build configuration was stale, which indirectly resulted in build failures (due to a code fence bug). The beta config should match the `main` config with respect to feature support.
ee39e34
to
c757961
Compare
@metamaskbot update-policies |
Policies updated |
Builds ready [7bd678f]
Page Load Metrics (136 ± 177 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25430 +/- ##
========================================
Coverage 64.92% 64.92%
========================================
Files 1385 1385
Lines 54875 54875
Branches 14409 14409
========================================
Hits 35625 35625
Misses 19250 19250 ☔ View full report in Codecov by Sentry. |
Missing release label release-12.0.0 on PR. Adding release label release-12.0.0 on PR and removing other release labels(release-12.1.0), as PR was cherry-picked in branch 12.0.0. |
Description
The Beta build configuration was stale, which indirectly resulted in build failures (due to a code fence bug). The beta config should match the
main
config with respect to feature support.Related issues
N/A
Manual testing steps
Run
yarn build --build-type beta --platform='chrome' dist
and see that it succeeds in creating a build. This is failing ondevelop
.Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist