Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Beta build configuration #25430

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jun 19, 2024

Description

The Beta build configuration was stale, which indirectly resulted in build failures (due to a code fence bug). The beta config should match the main config with respect to feature support.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

Run yarn build --build-type beta --platform='chrome' dist and see that it succeeds in creating a build. This is failing on develop.

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

The Beta build configuration was stale, which indirectly resulted in
build failures (due to a code fence bug). The beta config should match
the `main` config with respect to feature support.
@Gudahtt
Copy link
Member Author

Gudahtt commented Jun 19, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

@Gudahtt Gudahtt marked this pull request as ready for review June 19, 2024 21:37
@Gudahtt Gudahtt requested review from a team as code owners June 19, 2024 21:37
@metamaskbot
Copy link
Collaborator

Builds ready [7bd678f]
Page Load Metrics (136 ± 177 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint70968463
domContentLoaded8121111
load421746136369177
domInteractive8121111
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.92%. Comparing base (e54295d) to head (7bd678f).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25430   +/-   ##
========================================
  Coverage    64.92%   64.92%           
========================================
  Files         1385     1385           
  Lines        54875    54875           
  Branches     14409    14409           
========================================
  Hits         35625    35625           
  Misses       19250    19250           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gudahtt Gudahtt merged commit a16d1be into develop Jun 20, 2024
74 checks passed
@Gudahtt Gudahtt deleted the update-beta-build-config branch June 20, 2024 00:59
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 20, 2024
@metamaskbot metamaskbot added release-12.0.0 Issue or pull request that will be included in release 12.0.0 and removed release-12.1.0 Issue or pull request that will be included in release 12.1.0 labels Jul 10, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.0.0 on PR. Adding release label release-12.0.0 on PR and removing other release labels(release-12.1.0), as PR was cherry-picked in branch 12.0.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-extension-platform team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants