feat: adding / deleting additional RPC URLs #25452
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| import React from 'react'; | ||
| import { useDispatch } from 'react-redux'; | ||
| import { | ||
| BlockSize, | ||
| Display, | ||
| } from '../../../../helpers/constants/design-system'; | ||
| import { | ||
| Box, | ||
| ButtonPrimary, | ||
| ButtonPrimarySize, | ||
| ButtonSecondary, | ||
| ButtonSecondarySize, | ||
| Modal, | ||
| ModalBody, | ||
| ModalContent, | ||
| ModalHeader, | ||
| ModalOverlay, | ||
| } from '../../../component-library'; | ||
| import { useI18nContext } from '../../../../hooks/useI18nContext'; | ||
| import { | ||
| hideModal, | ||
| setEditedNetwork, | ||
| toggleNetworkMenu, | ||
| } from '../../../../store/actions'; | ||
|
|
||
| const ConfirmDeleteRpcUrlModal = () => { | ||
| const t = useI18nContext(); | ||
| const dispatch = useDispatch(); | ||
| return ( | ||
| <Modal | ||
| isClosedOnEscapeKey={true} | ||
| isClosedOnOutsideClick={true} | ||
| isOpen={true} | ||
| onClose={() => { | ||
| dispatch(setEditedNetwork()); | ||
| dispatch(hideModal()); | ||
| }} | ||
| > | ||
| <ModalOverlay /> | ||
| <ModalContent> | ||
| <ModalHeader>{t('confirmDeletion')}</ModalHeader> | ||
| <ModalBody> | ||
| <Box>{t('confirmRpcUrlDeletionMessage')}</Box> | ||
| <Box display={Display.Flex} gap={4} marginTop={6}> | ||
| <ButtonSecondary | ||
| width={BlockSize.Full} | ||
| size={ButtonSecondarySize.Lg} | ||
| onClick={() => { | ||
| dispatch(hideModal()); | ||
| dispatch(toggleNetworkMenu()); | ||
| }} | ||
| > | ||
| {t('back')} | ||
| </ButtonSecondary> | ||
| <ButtonPrimary | ||
| width={BlockSize.Full} | ||
| size={ButtonPrimarySize.Lg} | ||
| danger={true} | ||
|
There was a problem hiding this comment. same here you can just use |
||
| onClick={() => { | ||
| console.log('TODO: Delete RPc URL'); | ||
| }} | ||
| > | ||
| {t('deleteRpcUrl')} | ||
| </ButtonPrimary> | ||
| </Box> | ||
| </ModalBody> | ||
| </ModalContent> | ||
| </Modal> | ||
| ); | ||
| }; | ||
|
|
||
| export default ConfirmDeleteRpcUrlModal; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| import React from 'react'; | ||
| import { | ||
| Box, | ||
| ButtonPrimary, | ||
| ButtonPrimarySize, | ||
| FormTextField, | ||
| } from '../../../component-library'; | ||
| import { | ||
| BlockSize, | ||
| Display, | ||
| TextVariant, | ||
| } from '../../../../helpers/constants/design-system'; | ||
| import { useI18nContext } from '../../../../hooks/useI18nContext'; | ||
|
|
||
| const AddRpcUrlModal = () => { | ||
| const t = useI18nContext(); | ||
|
|
||
| return ( | ||
| <Box padding={4}> | ||
| <FormTextField | ||
| id="additional-rpc-url" | ||
| label={t('additionalRpcUrl')} | ||
| labelProps={{ | ||
| children: undefined, | ||
|
There was a problem hiding this comment. do we need to specify the value of children to undefined here? doesn't this take undefined by default ? There was a problem hiding this comment. i got a type error without it 
|
||
| variant: TextVariant.bodySmMedium, | ||
| }} | ||
| /> | ||
|
|
||
| <ButtonPrimary | ||
| size={ButtonPrimarySize.Lg} | ||
| display={Display.Block} | ||
| width={BlockSize.Full} | ||
| marginTop={8} | ||
| marginLeft={'auto'} | ||
| marginRight={'auto'} | ||
| > | ||
| {t('addUrl')} | ||
| </ButtonPrimary> | ||
| </Box> | ||
|
There was a problem hiding this comment. if we decide to include input validation here, it would be a good idea to write unit tests for this modal with the different scenarios ( |
||
| ); | ||
| }; | ||
|
|
||
| export default AddRpcUrlModal; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think
={true}is required here; I think the presence of the attribute inferstrue