-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue where queued request counts were not included in logic to reroute from home screen and close notification #25454
Conversation
…eroute from home screen and close notification
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Verified that this resolves the issue for me |
ce2bda5
to
34b4be2
Compare
const unapprovedTxRequests = getApprovalRequestsByType( | ||
state, | ||
ApprovalType.Transaction, | ||
); | ||
return ( | ||
hasUnapprovedTransactionsInCurrentNetwork(state) || | ||
unapprovedTxRequests.length > 0 || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we queue requests on different dapps which can be on different networks now we don't want to restrict this boolean check to only transactions that match the currently selected network. I'm not actually sure how there could have been pending transactions on different networks previously that necessitated this check 🤔... but I might be forgetting something
Builds ready [234c8ab]
Page Load Metrics (258 ± 293 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25454 +/- ##
===========================================
- Coverage 65.22% 65.21% -0.02%
===========================================
Files 1405 1405
Lines 55528 55530 +2
Branches 14587 14583 -4
===========================================
- Hits 36218 36209 -9
- Misses 19310 19321 +11 ☔ View full report in Codecov by Sentry. |
Builds ready [3a2f12c]
Page Load Metrics (47 ± 4 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
We introduced logic to add queued requests (pending requests not yet in the
ApprovalController
) to the trayIcon badge number, but failed to account for these requests in two other crucial spots:Related issues
Fixes: #25412
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2677
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2024-06-20.at.4.51.16.PM.mov
After
Screen.Recording.2024-06-20.at.4.44.57.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist