-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): Restrict test-e2e-firefox-flask & test-e2e-firefox-confirmation-redesign jobs to develop, master, and release branches #25469
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25469 +/- ##
========================================
Coverage 70.44% 70.44%
========================================
Files 1274 1274
Lines 44080 44080
Branches 12453 12453
========================================
Hits 31051 31051
Misses 13029 13029 ☔ View full report in Codecov by Sentry. |
567edcc
to
3451882
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Builds ready [3451882]
Page Load Metrics (48 ± 4 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3451882
to
24ecb61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Builds ready [24ecb61]
Page Load Metrics (53 ± 17 ms)
Bundle size diffs
|
Description
This PR aims to update our CI pipeline to ensure that
test-e2e-firefox-flask
andtest-e2e-firefox-confirmation-redesign
jobs only run on develop, Release branches, and master.We don't want these jobs to run on every PR anymore.
Also: Giving the
prep-build-test-flask-mv2
andprep-build-confirmation-redesign-test-mv2
(prerequisite steps) the same restriction. Thanks @DDDDDanicaRelated issues
Fixes: #25233
Manual testing steps
test-e2e-firefox-flask
nortest-e2e-firefox-confirmation-redesign
jobs should run on this pipelineScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist