Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Restrict test-e2e-firefox-flask & test-e2e-firefox-confirmation-redesign jobs to develop, master, and release branches #25469

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

vthomas13
Copy link
Contributor

@vthomas13 vthomas13 commented Jun 21, 2024

Description

This PR aims to update our CI pipeline to ensure that test-e2e-firefox-flask and test-e2e-firefox-confirmation-redesign jobs only run on develop, Release branches, and master.

We don't want these jobs to run on every PR anymore.

Also: Giving the prep-build-test-flask-mv2 and prep-build-confirmation-redesign-test-mv2 (prerequisite steps) the same restriction. Thanks @DDDDDanica

Open in GitHub Codespaces

Related issues

Fixes: #25233

Manual testing steps

  1. Neither test-e2e-firefox-flask nor test-e2e-firefox-confirmation-redesign jobs should run on this pipeline
  2. They should run when merging to develop, RC branch, and prod

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vthomas13 vthomas13 requested review from kumavis and a team as code owners June 21, 2024 15:12
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.44%. Comparing base (fcb4265) to head (24ecb61).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25469   +/-   ##
========================================
  Coverage    70.44%   70.44%           
========================================
  Files         1274     1274           
  Lines        44080    44080           
  Branches     12453    12453           
========================================
  Hits         31051    31051           
  Misses       13029    13029           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vthomas13 vthomas13 changed the title Restrict test-e2e-firefox-flask & test-e2e-firefox-confirmation-redesign jobs to develop, master, and release branches fix: Restrict test-e2e-firefox-flask & test-e2e-firefox-confirmation-redesign jobs to develop, master, and release branches Jun 21, 2024
@vthomas13 vthomas13 changed the title fix: Restrict test-e2e-firefox-flask & test-e2e-firefox-confirmation-redesign jobs to develop, master, and release branches fix(ci): Restrict test-e2e-firefox-flask & test-e2e-firefox-confirmation-redesign jobs to develop, master, and release branches Jun 21, 2024
Copy link
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot
Copy link
Collaborator

Builds ready [3451882]
Page Load Metrics (48 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6310579105
domContentLoaded8191021
load40764894
domInteractive8191021
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [24ecb61]
Page Load Metrics (53 ± 17 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint62294884823
domContentLoaded8131011
load39207533617
domInteractive8131011
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@vthomas13 vthomas13 merged commit aac1975 into develop Jun 24, 2024
69 checks passed
@vthomas13 vthomas13 deleted the ff-develop-master-rc-only branch June 24, 2024 20:05
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Restrict test-e2e-firefox-flask & test-e2e-firefox-confirmation-redesign jobs to Specific Branches
5 participants