ci: Adding node-linux-medium executor #25476

vthomas13 · 2024-06-21T18:16:52Z

Description

This PR implements a suggestion from @davidmurdoch to use linux machine image to reduce CI costs on the build steps in our pipeline. Starting with the build steps, we want to optimize for cost for any tests that can support a linux executor.

Related issues

Fixes: #25229

Manual testing steps

Check CI

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-06-21T18:17:03Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov · 2024-06-21T21:27:14Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.44%. Comparing base (f6acedb) to head (e4472a3).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #25476   +/-   ##
========================================
  Coverage    70.44%   70.44%           
========================================
  Files         1274     1274           
  Lines        44078    44078           
  Branches     12453    12453           
========================================
  Hits         31049    31049           
  Misses       13029    13029

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

davidmurdoch

🚀 We'll need to follow up on this PR in a week or so to measure credit usage to be sure we are saving $$$$$s

metamaskbot · 2024-06-21T21:40:09Z

Builds ready [2eedad6]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (170 ± 227 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	137	95	18	9
		domContentLoaded	9	39	14	7	3
		load	42	2229	170	472	227
		domInteractive	9	39	14	7	3

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

hjetpoluru

LGTM

HowardBraham

This should reduce credits per workflow, since Linux VM medium costs 10 credits per minute, and Docker Medium+ costs 15 credits per minute. As long as we don't somehow expand our minutes by 50%.
https://circleci.com/product/features/resource-classes/

There are a few more jobs that I noticed can use node-linux-medium:

prep-build
prep-build-mv2
prep-build-mmi
prep-build-flask
prep-build-flask-mv2
prep-build-test-mmi-playwright

HowardBraham · 2024-06-21T23:40:47Z

.circleci/config.yml

@@ -13,6 +13,12 @@ executors:
    resource_class: medium
    environment:
      NODE_OPTIONS: --max_old_space_size=3072
+  node-linux-medium:
+    machine:
+      image: ubuntu-2204:2024.04.4


We're in an Ubuntu LTS transition period. I think we might as well go with the next version, which is
ubuntu-2404:2024.05.1

metamaskbot · 2024-06-24T15:05:57Z

Builds ready [0d2c654]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (50 ± 4 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	71	96	82	7	3
		domContentLoaded	9	20	11	2	1
		load	42	73	50	9	4
		domInteractive	9	20	11	2	1

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

Gudahtt · 2024-06-24T16:21:52Z

.circleci/config.yml

+      image: ubuntu-2404:2024.05.1
+    resource_class: medium #// linux medium: 2 CPUs, 7.5 GB RAM, 10 credits/min
+    environment:
+      NODE_OPTIONS: --max_old_space_size=6144


Curious that we're allowing for a larger heap here than on medium+. I guess there should be adequate room though, as long as we're not running multiple Node.js processes in one job.

Gudahtt

LGTM!

metamaskbot · 2024-06-24T16:59:30Z

Builds ready [e4472a3]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (220 ± 245 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	64	228	97	49	24
		domContentLoaded	8	19	11	3	2
		load	40	1778	220	511	245
		domInteractive	8	19	11	3	2

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

vthomas13 requested review from kumavis and a team as code owners June 21, 2024 18:16

metamaskbot added the team-extension-platform label Jun 21, 2024

vthomas13 force-pushed the node-linux-medium-executor branch 2 times, most recently from 683fc5c to 2eedad6 Compare June 21, 2024 21:06

vthomas13 requested review from davidmurdoch, HowardBraham, danjm, DDDDDanica and Gudahtt June 21, 2024 21:31

davidmurdoch previously approved these changes Jun 21, 2024

View reviewed changes

DDDDDanica previously approved these changes Jun 21, 2024

View reviewed changes

hjetpoluru self-requested a review June 21, 2024 22:29

hjetpoluru previously approved these changes Jun 21, 2024

View reviewed changes

HowardBraham requested changes Jun 21, 2024

View reviewed changes

vthomas13 dismissed stale reviews from hjetpoluru, DDDDDanica, and davidmurdoch via 0d2c654 June 24, 2024 14:19

vthomas13 force-pushed the node-linux-medium-executor branch from 2eedad6 to 0d2c654 Compare June 24, 2024 14:19

vthomas13 requested a review from HowardBraham June 24, 2024 14:22

HowardBraham approved these changes Jun 24, 2024

View reviewed changes

vthomas13 requested a review from itsyoboieltr June 24, 2024 15:41

davidmurdoch approved these changes Jun 24, 2024

View reviewed changes

vthomas13 added 3 commits June 24, 2024 12:16

testing node-linux-medium

341ad78

removing sudo for node-linux-medium

f26cdc1

more jobs using linux executor

e4472a3

vthomas13 force-pushed the node-linux-medium-executor branch from 0d2c654 to e4472a3 Compare June 24, 2024 16:16

Gudahtt reviewed Jun 24, 2024

View reviewed changes

Gudahtt approved these changes Jun 24, 2024

View reviewed changes

vthomas13 merged commit 230dec7 into develop Jun 24, 2024
73 checks passed

vthomas13 deleted the node-linux-medium-executor branch June 24, 2024 17:14

github-actions bot locked and limited conversation to collaborators Jun 24, 2024

metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: Adding node-linux-medium executor #25476

ci: Adding node-linux-medium executor #25476

vthomas13 commented Jun 21, 2024 •

edited

Loading

github-actions bot commented Jun 21, 2024

codecov bot commented Jun 21, 2024 •

edited

Loading

davidmurdoch left a comment

metamaskbot commented Jun 21, 2024

hjetpoluru left a comment

HowardBraham left a comment

HowardBraham Jun 21, 2024

metamaskbot commented Jun 24, 2024

Gudahtt Jun 24, 2024

Gudahtt left a comment

metamaskbot commented Jun 24, 2024

ci: Adding node-linux-medium executor #25476

ci: Adding node-linux-medium executor #25476

Conversation

vthomas13 commented Jun 21, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jun 21, 2024

codecov bot commented Jun 21, 2024 • edited Loading

Codecov Report

davidmurdoch left a comment

Choose a reason for hiding this comment

metamaskbot commented Jun 21, 2024

hjetpoluru left a comment

Choose a reason for hiding this comment

HowardBraham left a comment

Choose a reason for hiding this comment

HowardBraham Jun 21, 2024

Choose a reason for hiding this comment

metamaskbot commented Jun 24, 2024

Gudahtt Jun 24, 2024

Choose a reason for hiding this comment

Gudahtt left a comment

Choose a reason for hiding this comment

metamaskbot commented Jun 24, 2024

vthomas13 commented Jun 21, 2024 •

edited

Loading

codecov bot commented Jun 21, 2024 •

edited

Loading