Commits on Jun 24, 2024

1. v11.16.14

   

   danjm committed Jun 24, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for af3e2cd
   • Browse repository at this point

   Copy the full SHA

   af3e2cd View commit details

   Browse the repository at this point in the history

2. fix(swaps): fix to round gas values to integer (#25488) (#25495) …

   <!--
   Please submit this PR as a draft initially.
   Do not mark it as "Ready for review" until the template has been
   completely filled out, and PR status checks have passed at least once.
   -->
   
   This is a cherry pick PR for #25488
   
   <!--
   Write a short description of the changes included in this pull request,
   also include relevant motivation and context. Have in mind the following
   questions:
   1. What is the reason for the change?
   2. What is the improvement/solution? -->
   
   [![Open in GitHub
   
   Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25488?quickstart=1)
   
   Fixes:
   
   1. Go to this page... 2.
   3.
   
   <!-- If applicable, add screenshots and/or recordings to visualize the
   before and after of your change. -->
   
   <!-- [screenshots/recordings] -->
   
   <!-- [screenshots/recordings] -->
   
   - [x] I've followed [MetaMask Contributor
   Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
   Extension Coding
   
   Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
   - [x] I've completed the PR template to the best of my ability
   - [x] I’ve included tests if applicable
   - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
   if applicable
   - [x] I’ve applied the right labels on the PR (see [labeling
   guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
   Not required for external contributors.
   
   - [x] I've manually tested the PR (e.g. pull and build branch, run the
   app, test code being changed).
   - [ ] I confirm that this PR addresses all acceptance criteria described
   in the ticket it closes and includes the necessary testing evidence such
   as recordings and or screenshots.
   
   ---------
   
   
   <!--
   Please submit this PR as a draft initially.
   Do not mark it as "Ready for review" until the template has been
   completely filled out, and PR status checks have passed at least once.
   -->
   
   ## **Description**
   
   <!--
   Write a short description of the changes included in this pull request,
   also include relevant motivation and context. Have in mind the following
   questions:
   1. What is the reason for the change?
   2. What is the improvement/solution?
   -->
   
   [![Open in GitHub
   Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25495?quickstart=1)
   
   ## **Related issues**
   
   Fixes:
   
   ## **Manual testing steps**
   
   1. Go to this page...
   2.
   3.
   
   ## **Screenshots/Recordings**
   
   <!-- If applicable, add screenshots and/or recordings to visualize the
   before and after of your change. -->
   
   ### **Before**
   
   <!-- [screenshots/recordings] -->
   
   ### **After**
   
   <!-- [screenshots/recordings] -->
   
   ## **Pre-merge author checklist**
   
   - [ ] I've followed [MetaMask Contributor
   Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
   Extension Coding
   Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
   - [ ] I've completed the PR template to the best of my ability
   - [ ] I’ve included tests if applicable
   - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
   if applicable
   - [ ] I’ve applied the right labels on the PR (see [labeling
   guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
   Not required for external contributors.
   
   ## **Pre-merge reviewer checklist**
   
   - [ ] I've manually tested the PR (e.g. pull and build branch, run the
   app, test code being changed).
   - [ ] I confirm that this PR addresses all acceptance criteria described
   in the ticket it closes and includes the necessary testing evidence such
   as recordings and or screenshots.
   
   Co-authored-by: Nicolas Ferro <nicolaspatricioferro@gmail.com>

   

   infiniteflower and nikoferro authored Jun 24, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for c910b91
   • Browse repository at this point

   Copy the full SHA

   c910b91 View commit details

   Browse the repository at this point in the history