Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move keyring snap permissions file #25491

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Jun 24, 2024

Description

This PR moves the keyring-snaps-permissions file into the snap-keyring directory.

Related issues

None

Manual testing steps

Not applicable

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.62%. Comparing base (18ebe12) to head (7df81da).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25491   +/-   ##
========================================
  Coverage    69.62%   69.62%           
========================================
  Files         1344     1344           
  Lines        47795    47795           
  Branches     13190    13190           
========================================
  Hits         33273    33273           
  Misses       14522    14522           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gantunesr gantunesr marked this pull request as ready for review June 24, 2024 19:47
@gantunesr gantunesr requested a review from a team as a code owner June 24, 2024 19:47
@gantunesr gantunesr requested a review from a team as a code owner June 24, 2024 19:47
@metamaskbot
Copy link
Collaborator

Builds ready [7df81da]
Page Load Metrics (51 ± 16 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint68288884622
domContentLoaded9211031
load39196513416
domInteractive9211031
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 72 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@gantunesr gantunesr merged commit ec5cf7e into develop Jun 24, 2024
73 checks passed
@gantunesr gantunesr deleted the chore/move-keyring-snap-files branch June 24, 2024 23:59
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants