Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [Snaps E2E] Create test for snap dialog JSX functionality #25493

Merged
merged 10 commits into from
Jul 26, 2024

Conversation

bowensanders
Copy link
Contributor

@bowensanders bowensanders commented Jun 24, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes: #25224

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bowensanders bowensanders self-assigned this Jun 24, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.65%. Comparing base (1d33d6f) to head (7505d43).
Report is 10 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25493   +/-   ##
========================================
  Coverage    69.65%   69.65%           
========================================
  Files         1355     1355           
  Lines        48007    48007           
  Branches     13235    13235           
========================================
  Hits         33437    33437           
  Misses       14570    14570           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [01fd4ff]
Page Load Metrics (175 ± 194 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint752121213416
domContentLoaded107630188
load591937175405194
domInteractive107630188
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@bowensanders bowensanders marked this pull request as ready for review June 28, 2024 19:25
@bowensanders bowensanders requested a review from a team as a code owner June 28, 2024 19:25
@metamaskbot
Copy link
Collaborator

Builds ready [7505d43]
Page Load Metrics (669 ± 469 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint913131516330
domContentLoaded169839199
load592734669976469
domInteractive169839199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

sonarcloud bot commented Jul 25, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [cd43d7a]
Page Load Metrics (227 ± 231 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint732201103517
domContentLoaded10382273
load431691227480231
domInteractive10382273
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@Jonathansoufer Jonathansoufer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bowensanders bowensanders merged commit 3d93d82 into develop Jul 26, 2024
75 of 76 checks passed
@bowensanders bowensanders deleted the bowen/jsxtest branch July 26, 2024 11:05
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Jul 26, 2024
@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-snaps release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: [Snaps E2E] Create E2E test for JSX example snap
5 participants